Now pipeline function takes direct default values rather than dsp.PipelineParam. #110
Conversation
…elineParam. It simplifies the sample code a lot.
|
Other than that, |
|
/lgtm |
|
/approve |
|
/test presubmit-e2e-test |
5 similar comments
|
/test presubmit-e2e-test |
|
/test presubmit-e2e-test |
|
/test presubmit-e2e-test |
|
/test presubmit-e2e-test |
|
/test presubmit-e2e-test |
|
/test presubmit-sample-test |
|
/test presubmit-e2e-test |
|
The sample test is not successful at this moment. Removing the approved label for now. |
|
/retest presubmit-e2e-test |
3 similar comments
|
/retest presubmit-e2e-test |
|
/retest presubmit-e2e-test |
|
/retest presubmit-e2e-test |
|
run-frontend-integration-tests: Error: element (".tableRow") still not visible after 5000ms |
backend/Dockerfile
Outdated
| FROM python:3.5 as compiler | ||
|
|
||
| RUN apt-get update -y && \ | ||
| apt-get install --no-install-recommends -y -q default-jdk libssl-dev libffi-dev wget |
There was a problem hiding this comment.
are libssl-dev and libffi-dev needed?
doesn't seem to be needed for travis but i could be wrong.
https://github.com/kubeflow/pipelines/blob/master/.travis.yml#L20
|
/lgtm |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qimingj The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qimingj The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test presubmit-e2e-test |
| RUN apt-get update -y && \ | ||
| apt-get install --no-install-recommends -y -q default-jdk wget | ||
|
|
||
| RUN pip3 install setuptools==40.5.0 |
There was a problem hiding this comment.
Is this no auto-installed? Do we need the specific version?
There was a problem hiding this comment.
Yes per @gaoning777 's investigation.
|
|
||
| RUN pip3 install setuptools==40.5.0 | ||
|
|
||
| RUN wget http://central.maven.org/maven2/io/swagger/swagger-codegen-cli/2.3.1/swagger-codegen-cli-2.3.1.jar -O /tmp/swagger-codegen-cli.jar |
There was a problem hiding this comment.
Do we need this for compilation? The compiler probably runs fine without the swagger codegen or kubernetes.
|
Also fixes #358 |
…test xml outputs (kubeflow#110) Update Pipfile and lock file to reflect this
…vior. (kubeflow#110) * Uses release built images for scikitlearn and xgboost * More notes on release process * Added default tensorflow runtime version
Fix bug in previous report where Python test_util could not be run from outside the sdk/python/tests folder
Add V1.0.0 to stable
It simplifies the sample code a lot. Also updated all samples and tests.
This change is