Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): fixing cve (low severity), build(deps): bump sass from 1.80.6 to 1.83.0, and also type check #657

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

ederign
Copy link
Member

@ederign ederign commented Dec 16, 2024

Description

Issue:

Type-checking in progress...
ERROR in ./src/shared/utilities/markdown.ts:18:14
TS2339: Property 'setAttribute' does not exist on type 'Node'.
    16 |       // nodeType 1 = element type
    17 |       if (node.nodeType === 1 && node.nodeName.toLowerCase() === 'a') {
  > 18 |         node.setAttribute('rel', 'noopener noreferrer');
       |              ^^^^^^^^^^^^
    19 |       }
    20 |     });
    21 |

Found 1 error in 3399 ms.

I've also fixed broken dependabot PR: https://github.com/kubeflow/model-registry/pull/652/files

How Has This Been Tested?

Small sanity check on the app.

Merge criteria:

  • All the commits have been signed-off (To pass the DCO check)
  • The commits have meaningful messages; the author will squash them after approval or in case of manual merges will ask to merge with squash.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work.
  • [X ] Code changes follow the kubeflow contribution guidelines.

@google-oss-prow google-oss-prow bot added size/M and removed size/XS labels Dec 16, 2024
@ederign ederign changed the title fix(frontend): fixing cve (low severity and type check) and also typecheck fix(frontend): fixing cve (low severity and type check), build(deps): bump sass from 1.80.6 to 1.83.0, and also type check Dec 16, 2024
… bump sass from 1.80.6 to 1.83.0, and also type check

Signed-off-by: Eder Ignatowicz <ignatowicz@gmail.com>
@ederign ederign changed the title fix(frontend): fixing cve (low severity and type check), build(deps): bump sass from 1.80.6 to 1.83.0, and also type check fix(frontend): fixing cve (low severity), build(deps): bump sass from 1.80.6 to 1.83.0, and also type check Dec 16, 2024
@alexcreasy
Copy link
Contributor

/lgtm

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexcreasy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 62f6707 into kubeflow:main Dec 20, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants