fix(frontend): fixing cve (low severity and type check), build(deps):…

… bump sass from 1.80.6 to 1.83.0, and also type check Signed-off-by: Eder Ignatowicz <ignatowicz@gmail.com>
kubeflow · Dec 16, 2024 · d6bc756 · d6bc756
1 parent 6c40612
commit d6bc756
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 16 deletions.
diff --git a/clients/ui/frontend/package-lock.json b/clients/ui/frontend/package-lock.json
diff --git a/clients/ui/frontend/package.json b/clients/ui/frontend/package.json
@@ -81,7 +81,7 @@
     "react-refresh": "^0.14.2",
     "react-router-dom": "^7.0.2",
     "regenerator-runtime": "^0.14.1",
-    "sass": "^1.56.2",
+    "sass": "^1.83.0",
     "sass-loader": "^13.2.0",
     "serve": "^14.2.4",
     "speed-measure-webpack-plugin": "^1.5.0",
@@ -115,7 +115,7 @@
     "react": "^18",
     "react-dom": "^18",
     "react-router": "^7.0.2",
-    "sass": "^1.78.0",
+    "sass": "^1.83.0",
     "dompurify": "^3.2.3",
     "showdown": "^2.1.0",
     "classnames": "^2.2.6"

diff --git a/clients/ui/frontend/src/shared/utilities/markdown.ts b/clients/ui/frontend/src/shared/utilities/markdown.ts
@@ -13,8 +13,7 @@ export const markdownConverter = {
 
     // add hook to transform anchor tags
     DOMPurify.addHook('beforeSanitizeElements', (node) => {
-      // nodeType 1 = element type
-      if (node.nodeType === 1 && node.nodeName.toLowerCase() === 'a') {
+      if (node instanceof HTMLAnchorElement) {
         node.setAttribute('rel', 'noopener noreferrer');
       }
     });