Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added visualization server deployment and service yaml #359

Merged
merged 5 commits into from
Sep 19, 2019
Merged

Added visualization server deployment and service yaml #359

merged 5 commits into from
Sep 19, 2019

Conversation

ajchili
Copy link
Member

@ajchili ajchili commented Sep 14, 2019 •
edited by jlewi
Loading

Which issue is resolved by this Pull Request:
Resolves @kubeflow/pipelines #2101

Description of your changes:
Adds the Visualization Server deployment and service YAML to manifests.

Checklist:

  • Unit tests have been rebuilt:
    1. cd manifests/tests
    2. make generate
    3. make test

This change is Reviewable

@ajchili
Copy link
Member Author

ajchili commented Sep 14, 2019

/assign @IronPan

@ajchili
Copy link
Member Author

ajchili commented Sep 16, 2019

@jlewi I am running into issues generating tests. I get the following output when running make generate in the manifests/tests directory:

$ make generate
generating webhook-base_test.go from manifests/admission-webhook/webhook/base
generating bootstrap-base_test.go from manifests/admission-webhook/bootstrap/base
generating application-crds-base_test.go from manifests/application/application-crds/base
generating application-overlays-application_test.go from manifests/application/application/overlays/application
generating application-overlays-debug_test.go from manifests/application/application/overlays/debug
generating application-base_test.go from manifests/application/application/base
generating argo-overlays-istio_test.go from manifests/argo/overlays/istio
generating argo-base_test.go from manifests/argo/base
generating istio-ingress-overlays-cognito_test.go from manifests/aws/istio-ingress/overlays/cognito
generating istio-ingress-overlays-oidc_test.go from manifests/aws/istio-ingress/overlays/oidc
generating istio-ingress-base_test.go from manifests/aws/istio-ingress/base
generating fluentd-cloud-watch-base_test.go from manifests/aws/fluentd-cloud-watch/base
generating aws-efs-csi-driver-base_test.go from manifests/aws/aws-efs-csi-driver/base
generating nvidia-device-plugin-base_test.go from manifests/aws/nvidia-device-plugin/base
generating aws-fsx-csi-driver-base_test.go from manifests/aws/aws-fsx-csi-driver/base
generating aws-alb-ingress-controller-overlays-vpc_test.go from manifests/aws/aws-alb-ingress-controller/overlays/vpc
generating aws-alb-ingress-controller-base_test.go from manifests/aws/aws-alb-ingress-controller/base
generating cert-manager-crds-base_test.go from manifests/cert-manager/cert-manager-crds/base
generating cert-manager-base_test.go from manifests/cert-manager/cert-manager/base
generating basic-auth-overlays-istio_test.go from manifests/common/basic-auth/overlays/istio
generating basic-auth-base_test.go from manifests/common/basic-auth/base
generating ambassador-base_test.go from manifests/common/ambassador/base
generating spartakus-base_test.go from manifests/common/spartakus/base
generating centraldashboard-overlays-istio_test.go from manifests/common/centraldashboard/overlays/istio
generating centraldashboard-overlays-application_test.go from manifests/common/centraldashboard/overlays/application
generating centraldashboard-base_test.go from manifests/common/centraldashboard/base
generating dex-crds-overlays-ldap_test.go from manifests/dex-auth/dex-crds/overlays/ldap
generating dex-crds-base_test.go from manifests/dex-auth/dex-crds/base
generating dex-ldap-base_test.go from manifests/dex-auth/dex-ldap/base
generating keycloak-gatekeeper-base_test.go from manifests/dex-auth/keycloak-gatekeeper/base
generating dex-authenticator-base_test.go from manifests/dex-auth/dex-authenticator/base
generating iap-ingress-overlays-managed-cert_test.go from manifests/gcp/iap-ingress/overlays/managed-cert
generating iap-ingress-overlays-gcp-credentials_test.go from manifests/gcp/iap-ingress/overlays/gcp-credentials
generating iap-ingress-overlays-certmanager_test.go from manifests/gcp/iap-ingress/overlays/certmanager
generating iap-ingress-base_test.go from manifests/gcp/iap-ingress/base
generating gpu-driver-base_test.go from manifests/gcp/gpu-driver/base
generating cloud-endpoints-overlays-gcp-credentials_test.go from manifests/gcp/cloud-endpoints/overlays/gcp-credentials
generating cloud-endpoints-base_test.go from manifests/gcp/cloud-endpoints/base
generating basic-auth-ingress-overlays-managed-cert_test.go from manifests/gcp/basic-auth-ingress/overlays/managed-cert
generating basic-auth-ingress-overlays-gcp-credentials_test.go from manifests/gcp/basic-auth-ingress/overlays/gcp-credentials
generating basic-auth-ingress-overlays-certmanager_test.go from manifests/gcp/basic-auth-ingress/overlays/certmanager
generating basic-auth-ingress-base_test.go from manifests/gcp/basic-auth-ingress/base
generating prometheus-base_test.go from manifests/gcp/prometheus/base
generating istio-install-base_test.go from manifests/istio/istio-install/base
generating istio-crds-base_test.go from manifests/istio/istio-crds/base
generating istio-base_test.go from manifests/istio/istio/base
generating jupyter-web-app-overlays-istio_test.go from manifests/jupyter/jupyter-web-app/overlays/istio
generating jupyter-web-app-overlays-application_test.go from manifests/jupyter/jupyter-web-app/overlays/application
generating jupyter-web-app-base_test.go from manifests/jupyter/jupyter-web-app/base
generating notebook-controller-overlays-istio_test.go from manifests/jupyter/notebook-controller/overlays/istio
generating notebook-controller-overlays-application_test.go from manifests/jupyter/notebook-controller/overlays/application
generating notebook-controller-base_test.go from manifests/jupyter/notebook-controller/base
generating studyjob-base_test.go from manifests/katib-v1alpha1/studyjob/base
generating suggestion-base_test.go from manifests/katib-v1alpha1/suggestion/base
generating katib-ui-overlays-istio_test.go from manifests/katib-v1alpha1/katib-ui/overlays/istio
generating katib-ui-base_test.go from manifests/katib-v1alpha1/katib-ui/base
generating vizier-db-base_test.go from manifests/katib-v1alpha1/vizier-db/base
generating metrics-collector-base_test.go from manifests/katib-v1alpha1/metrics-collector/base
generating vizier-core-base_test.go from manifests/katib-v1alpha1/vizier-core/base
generating katib-controller-overlays-application_test.go from manifests/katib-v1alpha2/katib-controller/overlays/application
generating katib-controller-base_test.go from manifests/katib-v1alpha2/katib-controller/base
generating katib-manager-overlays-application_test.go from manifests/katib-v1alpha2/katib-manager/overlays/application
generating katib-manager-base_test.go from manifests/katib-v1alpha2/katib-manager/base
generating suggestion-overlays-application_test.go from manifests/katib-v1alpha2/suggestion/overlays/application
generating suggestion-base_test.go from manifests/katib-v1alpha2/suggestion/base
generating katib-ui-overlays-istio_test.go from manifests/katib-v1alpha2/katib-ui/overlays/istio
generating katib-ui-overlays-application_test.go from manifests/katib-v1alpha2/katib-ui/overlays/application
generating katib-ui-base_test.go from manifests/katib-v1alpha2/katib-ui/base
generating metrics-collector-overlays-application_test.go from manifests/katib-v1alpha2/metrics-collector/overlays/application
generating metrics-collector-base_test.go from manifests/katib-v1alpha2/metrics-collector/base
generating katib-db-overlays-application_test.go from manifests/katib-v1alpha2/katib-db/overlays/application
generating katib-db-base_test.go from manifests/katib-v1alpha2/katib-db/base
generating kfserving-crds-base_test.go from manifests/kfserving/kfserving-crds/base
generating kfserving-install-overlays-application_test.go from manifests/kfserving/kfserving-install/overlays/application
generating kfserving-install-base_test.go from manifests/kfserving/kfserving-install/base
generating knative-serving-install-base_test.go from manifests/knative/knative-serving-install/base
generating knative-serving-crds-base_test.go from manifests/knative/knative-serving-crds/base
generating kubebench-overlays-istio_test.go from manifests/kubebench/overlays/istio
generating kubebench-base_test.go from manifests/kubebench/base
generating metacontroller-base_test.go from manifests/metacontroller/base
generating metadata-overlays-istio_test.go from manifests/metadata/overlays/istio
generating metadata-overlays-application_test.go from manifests/metadata/overlays/application
generating metadata-base_test.go from manifests/metadata/base
generating modeldb-base_test.go from manifests/modeldb/base
generating mpi-operator-overlays-application_test.go from manifests/mpi-job/mpi-operator/overlays/application
generating mpi-operator-base_test.go from manifests/mpi-job/mpi-operator/base
generating mxnet-operator-overlays-application_test.go from manifests/mxnet-job/mxnet-operator/overlays/application
generating mxnet-operator-base_test.go from manifests/mxnet-job/mxnet-operator/base
generating pipelines-runner-base_test.go from manifests/pipeline/pipelines-runner/base
generating api-service-base_test.go from manifests/pipeline/api-service/base
generating scheduledworkflow-base_test.go from manifests/pipeline/scheduledworkflow/base
generating pipeline-visualization-service-base_test.go from manifests/pipeline/pipeline-visualization-service/base
cat: /Users/kirinpatel/Github/kubeflow/manifests/pipeline/pipeline-visualization-service/base/kustomization.yaml: No such file or directory
cat: /Users/kirinpatel/Github/kubeflow/manifests/pipeline/pipeline-visualization-service/base/kustomization.yaml: No such file or directory
cat: /Users/kirinpatel/Github/kubeflow/manifests/pipeline/pipeline-visualization-service/base/kustomization.yaml: No such file or directory
generating minio-overlays-minioPd_test.go from manifests/pipeline/minio/overlays/minioPd
generating minio-base_test.go from manifests/pipeline/minio/base
generating mysql-overlays-mysqlPd_test.go from manifests/pipeline/mysql/overlays/mysqlPd
generating mysql-base_test.go from manifests/pipeline/mysql/base
generating pipelines-ui-overlays-istio_test.go from manifests/pipeline/pipelines-ui/overlays/istio
generating pipelines-ui-base_test.go from manifests/pipeline/pipelines-ui/base
generating pipelines-viewer-base_test.go from manifests/pipeline/pipelines-viewer/base
generating persistent-agent-base_test.go from manifests/pipeline/persistent-agent/base
generating profiles-overlays-istio_test.go from manifests/profiles/overlays/istio
generating profiles-overlays-devices_test.go from manifests/profiles/overlays/devices
generating profiles-overlays-debug_test.go from manifests/profiles/overlays/debug
generating profiles-base_test.go from manifests/profiles/base
generating pytorch-job-crds-base_test.go from manifests/pytorch-job/pytorch-job-crds/base
generating pytorch-operator-overlays-application_test.go from manifests/pytorch-job/pytorch-operator/overlays/application
generating pytorch-operator-base_test.go from manifests/pytorch-job/pytorch-operator/base
generating seldon-core-operator-overlays-application_test.go from manifests/seldon/seldon-core-operator/overlays/application
generating seldon-core-operator-base_test.go from manifests/seldon/seldon-core-operator/base
generating tektoncd-install-overlays-istio_test.go from manifests/tektoncd/tektoncd-install/overlays/istio
generating tektoncd-install-base_test.go from manifests/tektoncd/tektoncd-install/base
generating tektoncd-crds-base_test.go from manifests/tektoncd/tektoncd-crds/base
generating tensorboard-overlays-istio_test.go from manifests/tensorboard/overlays/istio
generating tensorboard-base_test.go from manifests/tensorboard/base
generating tf-job-operator-overlays-istio_test.go from manifests/tf-training/tf-job-operator/overlays/istio
generating tf-job-operator-overlays-application_test.go from manifests/tf-training/tf-job-operator/overlays/application
generating tf-job-operator-base_test.go from manifests/tf-training/tf-job-operator/base
go fmt ./...
go: cannot find main module, but found .git/config in /Users/kirinpatel/github/kubeflow/manifests
        to create a module there, run:
        cd .. && go mod init
make: *** [generate] Error 1

@ajchili ajchili changed the title [WIP] Added visualization server deployment and service yaml Added visualization server deployment and service yaml Sep 17, 2019
@ajchili
Copy link
Member Author

ajchili commented Sep 17, 2019

/assign @jlewi @jinchihe @zhenghuiwang

@jlewi
Copy link
Contributor

jlewi commented Sep 17, 2019

@IronPan Can you review this please?

@ajchili for the test generation errors; make sure you are running from inside your ${GOPATH} @kkasravi wrote the unittests and is probably the best person to help with any issues.

jlewi
jlewi reviewed Sep 17, 2019
View reviewed changes
pipeline/pipeline-visualization-service/base/deployment.yaml Outdated
app: ml-pipeline-visualizationserver
spec:
containers:
- image: gcr.io/ml-pipeline/visualization-server:0.1.26
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Maybe drop the tag since you specify the tag in kustomization.yaml and a different one from the one you have here.

@jlewi
Copy link
Contributor

jlewi commented Sep 17, 2019

This LGTM but it would be great to get @IronPan or someone from the pipelines team to review and approve it.

@ajchili
Copy link
Member Author

ajchili commented Sep 17, 2019

@jlewi I will sync up with @IronPan to get an approval.

@ajchili
Copy link
Member Author

ajchili commented Sep 18, 2019

/retest

@IronPan
Copy link
Member

IronPan commented Sep 19, 2019

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 4a4f148 into kubeflow:master Sep 19, 2019
Tomcli pushed a commit to Tomcli/manifests that referenced this pull request Dec 11, 2020
@animeshsingh @ckadner
quick fix for SDK instructions (kubeflow#358)
f6e6144 
* Quick fix in SDK documentation

Takes some excerpts from Christian's website PR. 

I will be revisiting after release to figure out the overlap with User guide.

* SDK Packages Overview (kubeflow#359)

Co-authored-by: Christian Kadner <ckadner@us.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlewi jlewi jlewi left review comments

@jinchihe jinchihe jinchihe left review comments

@zhenghuiwang zhenghuiwang Awaiting requested review from zhenghuiwang

Assignees

@jlewi jlewi

@IronPan IronPan

@jinchihe jinchihe

Labels
approved cla: yes lgtm size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ajchili @jlewi @IronPan @k8s-ci-robot @jinchihe @googlebot @zhenghuiwang