Skip to content

Commit

Permalink
Added visualization server deployment and service yaml (#359)
Browse files Browse the repository at this point in the history
* Added visualization server deployment and service yaml

* Added new line

* Completed PR checklist

* Add kustomization.yaml

Forgot to include it in previous commit

* Addressed nit from @jlewi
  • Loading branch information
ajchili authored and k8s-ci-robot committed Sep 19, 2019
1 parent b91942c commit 4a4f148
Show file tree
Hide file tree
Showing 4 changed files with 113 additions and 0 deletions.
21 changes: 21 additions & 0 deletions pipeline/pipeline-visualization-service/base/deployment.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
apiVersion: apps/v1beta2
kind: Deployment
metadata:
labels:
app: ml-pipeline-visualizationserver
name: ml-pipeline-visualizationserver
spec:
selector:
matchLabels:
app: ml-pipeline-visualizationserver
template:
metadata:
labels:
app: ml-pipeline-visualizationserver
spec:
containers:
- image: gcr.io/ml-pipeline/visualization-server
imagePullPolicy: IfNotPresent
name: ml-pipeline-visualizationserver
ports:
- containerPort: 8888
10 changes: 10 additions & 0 deletions pipeline/pipeline-visualization-service/base/kustomization.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization
nameprefix: ml-pipeline-
commonLabels:
app: ml-pipeline-visualizationserver
resources:
- service.yaml
images:
- name: gcr.io/ml-pipeline/visualization-server
newTag: '0.1.27'
12 changes: 12 additions & 0 deletions pipeline/pipeline-visualization-service/base/service.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
apiVersion: v1
kind: Service
metadata:
name: ml-pipeline-visualizationserver
spec:
ports:
- name: http
port: 8888
protocol: TCP
targetPort: 8888
selector:
app: ml-pipeline-visualizationserver
70 changes: 70 additions & 0 deletions tests/pipeline-visualization-service-base_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,70 @@
package tests_test

import (
"sigs.k8s.io/kustomize/k8sdeps/kunstruct"
"sigs.k8s.io/kustomize/k8sdeps/transformer"
"sigs.k8s.io/kustomize/pkg/fs"
"sigs.k8s.io/kustomize/pkg/loader"
"sigs.k8s.io/kustomize/pkg/resmap"
"sigs.k8s.io/kustomize/pkg/resource"
"sigs.k8s.io/kustomize/pkg/target"
"testing"
)

func writePipelineVisualizationServiceBase(th *KustTestHarness) {
th.writeF("/manifests/pipeline/pipeline-visualization-service/base/service.yaml", `
apiVersion: v1
kind: Service
metadata:
name: ml-pipeline-visualizationserver
spec:
ports:
- name: http
port: 8888
protocol: TCP
targetPort: 8888
selector:
app: ml-pipeline-visualizationserver
`)
th.writeK("/manifests/pipeline/pipeline-visualization-service/base", `
apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization
nameprefix: ml-pipeline-
commonLabels:
app: ml-pipeline-visualizationserver
resources:
- service.yaml
images:
- name: gcr.io/ml-pipeline/visualization-server
newTag: '0.1.27'
`)
}

func TestPipelineVisualizationServiceBase(t *testing.T) {
th := NewKustTestHarness(t, "/manifests/pipeline/pipeline-visualization-service/base")
writePipelineVisualizationServiceBase(th)
m, err := th.makeKustTarget().MakeCustomizedResMap()
if err != nil {
t.Fatalf("Err: %v", err)
}
expected, err := m.EncodeAsYaml()
if err != nil {
t.Fatalf("Err: %v", err)
}
targetPath := "../pipeline/pipeline-visualization-service/base"
fsys := fs.MakeRealFS()
_loader, loaderErr := loader.NewLoader(targetPath, fsys)
if loaderErr != nil {
t.Fatalf("could not load kustomize loader: %v", loaderErr)
}
rf := resmap.NewFactory(resource.NewFactory(kunstruct.NewKunstructuredFactoryImpl()))
kt, err := target.NewKustTarget(_loader, rf, transformer.NewFactoryImpl())
if err != nil {
th.t.Fatalf("Unexpected construction error %v", err)
}
actual, err := kt.MakeCustomizedResMap()
if err != nil {
t.Fatalf("Err: %v", err)
}
th.assertActualEqualsExpected(actual, string(expected))
}

0 comments on commit 4a4f148

Please sign in to comment.