Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a configmap generator for the spawner_ui_config.yaml #1013

Merged
merged 4 commits into from
Mar 27, 2020

Commits on Mar 25, 2020

  1. Use a configmap generator for the spawner_ui_config.yaml

    * Using a configmap generator is a bit cleaner because we can store
      the configuration file in a external file rather than inlining it in
      the config map.
    
    * Using a configmap generator also has the advantage that kustomize will
      generate a unique name based on a hash of the content.
    
      * This has the advantage that if a user updates the config, the hash
        would change so deployments would automatically be redeployed in order
        to pick up the config changes.
    
    * Also update the default image used in the configmap to fix kubeflow#1010
    Jeremy Lewi committed Mar 25, 2020
    Configuration menu
    Copy the full SHA
    8a14f7d View commit details
    Browse the repository at this point in the history
  2. Rebase and regenerate the tests.

    Jeremy Lewi committed Mar 25, 2020
    Configuration menu
    Copy the full SHA
    3e3d327 View commit details
    Browse the repository at this point in the history
  3. * The deployment for the UI needs to use the original name of

      the jupyter web app config map without the prefix/suffix.
    Jeremy Lewi committed Mar 25, 2020
    Configuration menu
    Copy the full SHA
    150cbdd View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2020

  1. Update expected tests.

    Jeremy Lewi committed Mar 26, 2020
    Configuration menu
    Copy the full SHA
    e1b8705 View commit details
    Browse the repository at this point in the history