jupyter web app config is defaulting to an old image #1010
Labels
Comments
|
Issue-Label Bot is automatically applying the labels:
Please mark this comment with 👍 or 👎 to give our bot feedback! |
jlewi
pushed a commit
to jlewi/manifests
that referenced
this issue
Mar 25, 2020
* Using a configmap generator is a bit cleaner because we can store
the configuration file in a external file rather than inlining it in
the config map.
* Using a configmap generator also has the advantage that kustomize will
generate a unique name based on a hash of the content.
* This has the advantage that if a user updates the config, the hash
would change so deployments would automatically be redeployed in order
to pick up the config changes.
* Also update the default image used in the configmap to fix kubeflow#1010
k8s-ci-robot
pushed a commit
that referenced
this issue
Mar 27, 2020
* Use a configmap generator for the spawner_ui_config.yaml
* Using a configmap generator is a bit cleaner because we can store
the configuration file in a external file rather than inlining it in
the config map.
* Using a configmap generator also has the advantage that kustomize will
generate a unique name based on a hash of the content.
* This has the advantage that if a user updates the config, the hash
would change so deployments would automatically be redeployed in order
to pick up the config changes.
* Also update the default image used in the configmap to fix #1010
* Rebase and regenerate the tests.
* * The deployment for the UI needs to use the original name of
the jupyter web app config map without the prefix/suffix.
* Update expected tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The default is set here
manifests/jupyter/jupyter-web-app/base/config-map.yaml
Line 24 in 4d8b1cb
To an old 0.7 image. It should probably be updated to one of the images listed in the configmap below.
e.g.
manifests/jupyter/jupyter-web-app/base/config-map.yaml
Line 27 in 4d8b1cb
@kimwnasptd could you submit a fix for this please?
The text was updated successfully, but these errors were encountered: