Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suggestion: Refactor #21

Merged
merged 1 commit into from
Apr 9, 2018
Merged

suggestion: Refactor #21

merged 1 commit into from
Apr 9, 2018

Conversation

gaocegege
Copy link
Member

@gaocegege gaocegege commented Apr 8, 2018

  • Fix a typo in hyperband service MaxParallel
  • Move the service to the suggestion package
  • Move the port to the suggestion package
  • Fix import order and some variable names

Close #18

Signed-off-by: Ce Gao gaoce@caicloud.io

- Fix a typo in hyperband service `MaxParallel`
- Move the service to the suggestion package
- Move the port to the suggestion package

Signed-off-by: Ce Gao <gaoce@caicloud.io>
@gaocegege
Copy link
Member Author

/assign @YujiOshima

@YujiOshima
Copy link
Contributor

YujiOshima commented Apr 9, 2018

@gaocegege Thanks!
/lgtm

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: YujiOshima

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gaocegege gaocegege merged commit 3e0c030 into kubeflow:master Apr 9, 2018
@gaocegege gaocegege deleted the suggestion branch April 9, 2018 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants