Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[suggestion] Move the logic about random service to random package #18

Closed
gaocegege opened this issue Apr 7, 2018 · 0 comments
Closed

[suggestion] Move the logic about random service to random package #18

gaocegege opened this issue Apr 7, 2018 · 0 comments
Labels
area/suggestion good first issue Good for newcomers priority/p3

Comments

@gaocegege
Copy link
Member

We put the struct RandomSuggestService in suggestion/suggestionService.go, I think we should move it to suggestion/random to improve readability.
@gaocegege gaocegege mentioned this issue Apr 8, 2018
Merged
kuikuikuizzZ pushed a commit to kuikuikuizzZ/katib that referenced this issue Jan 20, 2021
@whalecold
chore: Add helm chart for katib and katib db (kubeflow#18)
809868a 
* chore: Add helm chart for katib and katib db

* add crds for katib

Co-authored-by: whalecold <zhenglisheng@caicloud.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/suggestion good first issue Good for newcomers priority/p3
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gaocegege