Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kwa-actual-links-in-tables] Make links in KWA's tables actual links #2090

Merged

Conversation

elenzio9
Copy link
Contributor

In this PR:

  • Update the COMMIT file to include the latest changes of kubeflow/kubeflow
  • Make the links of the experiments table actual links
  • Make the links of the trials table actual links

image1
image2

Related PR: kubeflow/kubeflow#6864

Signed-off-by: Elena Zioga <elena@arrikto.com>
Make KWA's experiments table links actual links by using the new LinkValue
class.

Signed-off-by: Elena Zioga <elena@arrikto.com>
Make KWA's trials table links actual links by using the new LinkValue
class.

Signed-off-by: Elena Zioga <elena@arrikto.com>
@tenzen-y
Copy link
Member

/assign @kimwnasptd @orfeas-k

@kimwnasptd
Copy link
Member

Looks good! Glad to see we are following the same pattern here as well. The code looks good as well

/lgtm
/approve

@google-oss-prow google-oss-prow bot added the lgtm label Jan 26, 2023
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elenzio9, kimwnasptd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants