-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kwa(front): Sort conditions table by timestamp #2067
kwa(front): Sort conditions table by timestamp #2067
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this update @orfeas-k!
/assign @kimwnasptd @elenzio9
Blocked by: #2070 |
@orfeas-k Can you rebase since we fixed CI? |
3d30d0b
to
d9ccbcb
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: orfeas-k The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@tenzen-y I just rebased and pushed, happy new year! |
@orfeas-k thanks for the update! Tested and worked as expected! |
@orfeas-k Could you rebase the branch on top of the latest |
Update COMMIT file to checkout to latest KF common commit and have conditions table sorted by timestamp by default. Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
d9ccbcb
to
9e9a423
Compare
New changes are detected. LGTM label has been removed. |
@elenzio9 Just rebased and pushed. |
I see that a GH action failed although nothing changed in the PR's file in comparison with before the |
@tenzen-y Sure, this makes total sense. Thanks for noticing! |
This is a follow-up PR to this and updates the COMMIT file to checkout to the latest KF commit and have the conditions table sorted by timestamp by default.