Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only validate Kubernetes Job #2025

Merged
merged 1 commit into from
Dec 3, 2022
Merged

Conversation

zhixian82
Copy link
Contributor

Fixes #2021

@google-cla
Copy link

google-cla bot commented Nov 21, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

return fmt.Errorf("unable to convert spec.TrialTemplate: %v to %v: %v", runSpec.Object, gvk.Kind, err)
}
// Validate only Kuernetes Job
if gvk.GroupVersion() != batchv1.SchemeGroupVersion {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check Kind as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@coveralls
Copy link

coveralls commented Nov 24, 2022

Coverage Status

Coverage decreased (-0.3%) to 73.265% when pulling 3bfd39a on zhixian82:master into a5ef2db on kubeflow:master.

Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this update @zhixian82, just small nit from me.

if err != nil {
return fmt.Errorf("unable to convert spec.TrialTemplate: %v to %v: %v", runSpec.Object, gvk.Kind, err)
}
// Validate only Kuernetes Job
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Validate only Kuernetes Job
// Validate only Kubernetes Job

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@johnugeorge
Copy link
Member

@zhixian82 Can you do a rebase as well?

@zhixian82
Copy link
Contributor Author

@zhixian82 Can you do a rebase as well?

done

Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zhixian82 Thanks for the first awesome contribution!
/lgtm

/cc @andreyvelich @johnugeorge

@tenzen-y
Copy link
Member

tenzen-y commented Dec 2, 2022

/assign @andreyvelich @johnugeorge

@johnugeorge
Copy link
Member

/approve

Thanks @zhixian82

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnugeorge, zhixian82

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 55bdcbb into kubeflow:master Dec 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Katib doesn't support volcanoJob
5 participants