Fix Raw Logger E2E #3434
Merged
Fix Raw Logger E2E #3434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a small fix to the test_raw_logger.py/test_kserve_logger E2E test. This E2E test was creating a `message-dumper-raw` that was dependant on a Serverless setup, leading to the E2E to fail on an environment where Istio nor KNative are available. The fix is to add the right annotation to `message-dumper-raw` to deploy it in Raw mode, and adjust the logger URL of the `isvc-logger-raw` to point to the Kubernetes Service, rather than the KNative service. Signed-off-by: Edgar Hernández <23639005+israel-hdez@users.noreply.github.com>
|
There seems to be an issue with paddle which, IMO, is unrelated to these changes. |
|
/retest |
|
All checks are passing |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: israel-hdez, yuzisun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
TimKleinloog
pushed a commit
to TimKleinloog/kserve
that referenced
this pull request
Feb 19, 2024
This is a small fix to the test_raw_logger.py/test_kserve_logger E2E test. This E2E test was creating a `message-dumper-raw` that was dependant on a Serverless setup, leading to the E2E to fail on an environment where Istio nor KNative are available. The fix is to add the right annotation to `message-dumper-raw` to deploy it in Raw mode, and adjust the logger URL of the `isvc-logger-raw` to point to the Kubernetes Service, rather than the KNative service. Signed-off-by: Edgar Hernández <23639005+israel-hdez@users.noreply.github.com> Signed-off-by: Tim Kleinloog <tkleinloog@deeploy.ml>
TimKleinloog
pushed a commit
to TimKleinloog/kserve
that referenced
this pull request
Feb 20, 2024
This is a small fix to the test_raw_logger.py/test_kserve_logger E2E test. This E2E test was creating a `message-dumper-raw` that was dependant on a Serverless setup, leading to the E2E to fail on an environment where Istio nor KNative are available. The fix is to add the right annotation to `message-dumper-raw` to deploy it in Raw mode, and adjust the logger URL of the `isvc-logger-raw` to point to the Kubernetes Service, rather than the KNative service. Signed-off-by: Edgar Hernández <23639005+israel-hdez@users.noreply.github.com> Signed-off-by: Tim Kleinloog <tkleinloog@deeploy.ml>
timothyjlaurent
pushed a commit
to timothyjlaurent/kserve
that referenced
this pull request
Feb 21, 2024
This is a small fix to the test_raw_logger.py/test_kserve_logger E2E test. This E2E test was creating a `message-dumper-raw` that was dependant on a Serverless setup, leading to the E2E to fail on an environment where Istio nor KNative are available. The fix is to add the right annotation to `message-dumper-raw` to deploy it in Raw mode, and adjust the logger URL of the `isvc-logger-raw` to point to the Kubernetes Service, rather than the KNative service. Signed-off-by: Edgar Hernández <23639005+israel-hdez@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This is a small fix to the test_raw_logger.py/test_kserve_logger E2E test.
This E2E test was creating a
message-dumper-rawthat was dependent on a Serverless setup, leading to the E2E to fail on an environment where Istio nor KNative are available.The fix is to add the right annotation to
message-dumper-rawto deploy it in Raw mode, and adjust the logger URL of theisvc-logger-rawto point to the Kubernetes Service, rather than the KNative service.Release note: