Skip to content

Commit

Permalink
Fix Raw Logger E2E (kserve#3434)
Browse files Browse the repository at this point in the history
This is a small fix to the test_raw_logger.py/test_kserve_logger E2E test.

This E2E test was creating a `message-dumper-raw` that was dependant on a Serverless setup, leading to the E2E to fail on an environment where Istio nor KNative are available.

The fix is to add the right annotation to `message-dumper-raw` to deploy it in Raw mode, and adjust the logger URL of the `isvc-logger-raw` to point to the Kubernetes Service, rather than the KNative service.

Signed-off-by: Edgar Hernández <23639005+israel-hdez@users.noreply.github.com>
Signed-off-by: Tim Kleinloog <tkleinloog@deeploy.ml>
  • Loading branch information
israel-hdez authored and TimKleinloog committed Feb 19, 2024
1 parent c13111a commit bb9f51f
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions test/e2e/logger/test_raw_logger.py
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,8 @@ def test_kserve_logger():
isvc = V1beta1InferenceService(api_version=constants.KSERVE_V1BETA1,
kind=constants.KSERVE_KIND,
metadata=client.V1ObjectMeta(
name=msg_dumper, namespace=KSERVE_TEST_NAMESPACE),
name=msg_dumper, namespace=KSERVE_TEST_NAMESPACE,
annotations=annotations),
spec=V1beta1InferenceServiceSpec(predictor=predictor))

kserve_client.create(isvc)
Expand All @@ -60,7 +61,7 @@ def test_kserve_logger():
min_replicas=1,
logger=V1beta1LoggerSpec(
mode="all",
url="http://"+msg_dumper+"."+KSERVE_TEST_NAMESPACE+".svc.cluster.local"
url="http://"+msg_dumper+"-predictor."+KSERVE_TEST_NAMESPACE+".svc.cluster.local"
),
sklearn=V1beta1SKLearnSpec(
storage_uri='gs://kfserving-examples/models/sklearn/1.0/model',
Expand Down

0 comments on commit bb9f51f

Please sign in to comment.