Enhance client to push blobs, mount blobs, and push raw manifests #63

aochagavia · 2023-02-07T13:21:40Z

No description provided.

Updated default aks version to 1.20.7

…c .markdownlint.json --fix

Signed-off-by: Radu M <root@radu.sh> Co-authored-by: Taylor Thomas <thomastaylor312@users.noreply.github.com> Co-authored-by: Brian Hardock <brhardoc@microsoft.com>

Adds device plugin support

There were some places where we needed to unwrap the join error _and_ the Result. Also removed an import that was no longer needed

fix(*): Handles results in windows code

Signed-off-by: Radu M <root@radu.sh>

Add CODEOWNERS file

Explicitly specify license in Cargo.toml

We needed a way to know the concrete amount of memory or the number of CPUs eventually and we definitely needed it for the math for the downward API volume type. So this adds the parsing and conversion for it.

…est-0.16.0 Update rstest requirement from 0.15.0 to 0.16.0

Add async_read support for pull_blob API

Expose a feature of the reqwest crate that allows to use the system certificates. Signed-off-by: Flavio Castelli <fcastelli@suse.com>

…oots-features fix: rustls allow usage or system root certificates

@Xynnn007

What's Changed ============== * Bump actions/checkout from 3.0.2 to 3.1.0 by @dependabot in oras-project#47 * feat: enable Clone, Eq, PartialEq and Debug macro for RegistryAuth by @Xynnn007 in oras-project#48 * fix: address broken test by @flavio in oras-project#52 * Update rstest requirement from 0.15.0 to 0.16.0 by @dependabot in oras-project#55 * Add async_read support for pull_blob API by @arronwy in oras-project#54 * fix: rustls allow usage or system root certificates by @flavio in oras-project#56 == New Contributors * @Xynnn007 made their first contribution in oras-project#48 Signed-off-by: Flavio Castelli <fcastelli@suse.com>

- Added OCI Image Configuration structure named `ConfigFile` - Added an API to create a `Config` struct from `ConfigFile` Signed-off-by: Xynnn007 <xynnn@linux.alibaba.com>

feat: Add OCI Image Configuration structures

Bumps [actions/checkout](https://github.com/actions/checkout) from 3.1.0 to 3.2.0. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v3.1.0...v3.2.0) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>

…tions/actions/checkout-3.2.0 Bump actions/checkout from 3.1.0 to 3.2.0

Bumps [actions/checkout](https://github.com/actions/checkout) from 3.2.0 to 3.3.0. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v3.2.0...v3.3.0) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>

…tions/actions/checkout-3.3.0 Bump actions/checkout from 3.2.0 to 3.3.0

Signed-off-by: Ulf Lilleengen <lulf@redhat.com>

Bumps [engineerd/configurator](https://github.com/engineerd/configurator) from 0.0.8 to 0.0.9. - [Release notes](https://github.com/engineerd/configurator/releases) - [Commits](engineerd/configurator@v0.0.8...v0.0.9) --- updated-dependencies: - dependency-name: engineerd/configurator dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>

…tions/engineerd/configurator-0.0.9 Bump engineerd/configurator from 0.0.8 to 0.0.9

Add support for compiling to wasm32 architecture

Signed-off-by: Adolfo Ochagavía <adolfo@ochagavia.nl>

thomastaylor312

This is looking really great! Just one open question around the design of the API.

thomastaylor312 · 2023-02-28T20:42:54Z

src/client.rs

+        &self,
+        image: &Reference,
+        body: Vec<u8>,
+        content_type: HeaderValue,


This might be a cleaner API if this were to be H where H: TryInto<HeaderValue, Error = OciDistributionError> so people can pass anything that can be turned into a header value. Any thoughts on how you think this will be used?

I am using this function in an application that creates an OCI image in memory and pushes the result to the registry (see this blog post for details). The specific code is:

registry_client .push_manifest_raw( new_image_reference, image_manifest_json, OCI_IMAGE_MEDIA_TYPE.parse().unwrap(), ) .await?;

I experimented changing the line you mentioned to content_type: impl TryInto<HeaderValue, Error = OciDistributionError> and ran into problems, but impl TryInto<HeaderValue, Error = InvalidHeaderValue> did the trick ;)

flavio

Overall LGTM, I left a minor comment

flavio · 2023-03-02T09:25:52Z

src/client.rs

+        digest: &str,
+    ) -> Result<()> {
+        let base_url = self.to_v2_blob_upload_url(image);
+        let url = format!("{}?mount={}&from={}", base_url, digest, source.repository());


I might be a bit paranoid, but I would prefer to have the url built using the Url crate.

Using the query_pairs_mut method would allow us to do proper encoding of the query parameters

thomastaylor312 · 2023-03-02T22:59:51Z

Just so others know what happened, we removed some large binaries from our git history and overwrote history, so this got automatically closed.

@aochagavia feel free to reopen a new PR against main when you're ready!

kate-goldenring and others added 30 commits June 21, 2021 15:02

import from correct resources module

e017df3

Merge branch 'main' into device-plugin-support

71541ed

use device manager directory for plugin endpoints

5dfc26b

fix tests

ad50c51

fix docs compilation

ddcf19d

Updated default aks version to 1.20.7

05cbf8b

Merge pull request #633 from cmhamakawa/cmh/update

d4d6417

Updated default aks version to 1.20.7

add device plugin documentation

4e3bfac

wrap documentation text

5c3ec45

lint documentation with markdownlint 'docs/topics/plugin_system.md' -…

3123b6e

…c .markdownlint.json --fix

fix md list ordering

76a457e

add support for env vars and update docs

6d21cd7

delete any existing manager socket before creating a new one

1f93ffe

Move Wasmtime module instantiation out of spawn_blocking

cc2de7a

Signed-off-by: Radu M <root@radu.sh> Co-authored-by: Taylor Thomas <thomastaylor312@users.noreply.github.com> Co-authored-by: Brian Hardock <brhardoc@microsoft.com>

Run apt update on aarch64 and remove default features

f23a04a

Signed-off-by: Radu M <root@radu.sh> Co-authored-by: Taylor Thomas <thomastaylor312@users.noreply.github.com> Co-authored-by: Brian Hardock <brhardoc@microsoft.com>

Merge pull request #630 from radu-matei/update-wasmtime-v028

bdd93c9

address todos, nits, etc

54ea0fd

wrap in line documentation

e1f5b84

fix update_devices_map comment fmt

b27c7ca

document not allowing a plugin with existing plugin name to register

ae2098b

check that resource is in map before adding device

f96089d

Merge pull request #621 from kate-goldenring/device-plugin-support

9efb832

Adds device plugin support

fix(*): Handles results in windows code

c56db05

There were some places where we needed to unwrap the join error _and_ the Result. Also removed an import that was no longer needed

Merge pull request #638 from thomastaylor312/fix/windows_lints

f992f93

fix(*): Handles results in windows code

Add CODEOWNERS file

16cf5bc

Signed-off-by: Radu M <root@radu.sh>

Explicitly specify license in Cargo.toml

af8274b

Merge pull request #643 from radu-matei/codeowners

b4bbaf7

Add CODEOWNERS file

Merge pull request #644 from lfrancke/license

da85061

Explicitly specify license in Cargo.toml

k8s 1.21 upgrades

4846df7

feat(resources): Adds new quantity type for resources

407bc1b

We needed a way to know the concrete amount of memory or the number of CPUs eventually and we definitely needed it for the math for the downward API volume type. So this adds the parsing and conversion for it.

flavio and others added 15 commits December 12, 2022 19:36

Merge pull request oras-project#55 from krustlet/dependabot/cargo/rst…

29b8cfd

…est-0.16.0 Update rstest requirement from 0.15.0 to 0.16.0

Merge pull request oras-project#54 from arronwy/stream

68ecf58

Add async_read support for pull_blob API

fix: rustls allow usage or system root certificates

52eef3f

Expose a feature of the reqwest crate that allows to use the system certificates. Signed-off-by: Flavio Castelli <fcastelli@suse.com>

Merge pull request oras-project#56 from flavio/expose-rustls-native-r…

75f0ab8

…oots-features fix: rustls allow usage or system root certificates

feat: Add OCI Image Configuration structures

185814b

- Added OCI Image Configuration structure named `ConfigFile` - Added an API to create a `Config` struct from `ConfigFile` Signed-off-by: Xynnn007 <xynnn@linux.alibaba.com>

Merge pull request oras-project#57 from Xynnn007/feat-config

865faeb

feat: Add OCI Image Configuration structures

Merge pull request oras-project#59 from krustlet/dependabot/github_ac…

3f11341

…tions/actions/checkout-3.2.0 Bump actions/checkout from 3.1.0 to 3.2.0

Merge pull request oras-project#60 from krustlet/dependabot/github_ac…

1cae866

…tions/actions/checkout-3.3.0 Bump actions/checkout from 3.2.0 to 3.3.0

Add support for compiling to wasm32 architecture

73d63c2

Signed-off-by: Ulf Lilleengen <lulf@redhat.com>

Merge pull request oras-project#62 from krustlet/dependabot/github_ac…

05e13a3

…tions/engineerd/configurator-0.0.9 Bump engineerd/configurator from 0.0.8 to 0.0.9

Merge pull request oras-project#61 from lulf/wasm

2130b5e

Add support for compiling to wasm32 architecture

aochagavia requested review from thomastaylor312, bacongobbler and flavio as code owners February 7, 2023 13:21

aochagavia changed the title ~~Enhance client to push blobs, mount blobs, and push manifests~~ Enhance client to push blobs, mount blobs, and push raw manifests Feb 7, 2023

aochagavia force-pushed the client-enhancements branch 2 times, most recently from 485bb83 to 61ca662 Compare February 7, 2023 13:36

Enhance client to push blobs, mount blobs, and push raw manifests

eaaa5a9

Signed-off-by: Adolfo Ochagavía <adolfo@ochagavia.nl>

aochagavia force-pushed the client-enhancements branch from 61ca662 to eaaa5a9 Compare February 8, 2023 09:04

thomastaylor312 reviewed Feb 28, 2023

View reviewed changes

flavio mentioned this pull request Mar 2, 2023

Git history messy #18

Closed

flavio reviewed Mar 2, 2023

View reviewed changes

thomastaylor312 closed this Mar 2, 2023

thomastaylor312 force-pushed the main branch from 7058c8d to 77d2362 Compare March 2, 2023 17:16

aochagavia mentioned this pull request Mar 6, 2023

Enhance client to push blobs, mount blobs, and push raw manifests #66

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enhance client to push blobs, mount blobs, and push raw manifests #63

Enhance client to push blobs, mount blobs, and push raw manifests #63

aochagavia commented Feb 7, 2023

thomastaylor312 left a comment

thomastaylor312 Feb 28, 2023

aochagavia Mar 6, 2023

flavio left a comment

flavio Mar 2, 2023

thomastaylor312 commented Mar 2, 2023

Enhance client to push blobs, mount blobs, and push raw manifests #63

Enhance client to push blobs, mount blobs, and push raw manifests #63

Conversation

aochagavia commented Feb 7, 2023

thomastaylor312 left a comment

Choose a reason for hiding this comment

thomastaylor312 Feb 28, 2023

Choose a reason for hiding this comment

aochagavia Mar 6, 2023

Choose a reason for hiding this comment

flavio left a comment

Choose a reason for hiding this comment

flavio Mar 2, 2023

Choose a reason for hiding this comment

thomastaylor312 commented Mar 2, 2023