-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add OCI Image Configuration structures #57
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few small changes requested here.
How do you intend for this to be consumed? Does the user use the config type if they want it and then have to serialize it to Vec<u8>
? Or is there another way to make it easier? Just want to make sure I understand!
- Added OCI Image Configuration structure named `ConfigFile` - Added an API to create a `Config` struct from `ConfigFile` Signed-off-by: Xynnn007 <xynnn@linux.alibaba.com>
602c53c
to
185814b
Compare
I've added a new API
To me the first scenario is needed, because current impl uses an empty config, which may be detected as illegal image for some registries. Thus, I want to provide some detailed support for OCI Configuration and let users use it arbitrarily. For some configurations inside a registry may seem different from what the spec defines, I did not integrate deserialization of config into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for all the effort with this! Everything is looking good
feat: Add OCI Image Configuration structures
Related to #50, added structure definitions.