Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for compiling to wasm32 architecture #61

Merged
merged 1 commit into from
Jan 26, 2023

Conversation

lulf
Copy link
Contributor

@lulf lulf commented Jan 23, 2023

Most of the dependencies like reqwest already handle compilation for wasm32, so it is a matter of setting only the supported tokio features and guard some of the reqwest APIs that are not supported on wasm32.

The underlying motivation is to use sigstore on wasm32 architectures, but being able to work with OCI registries from WASM modules might come in handy as well.

Signed-off-by: Ulf Lilleengen <lulf@redhat.com>
Copy link
Contributor

@thomastaylor312 thomastaylor312 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor discussion item. Otherwise, this will be great!

Cargo.toml Show resolved Hide resolved
Copy link
Contributor

@flavio flavio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice contribution. Thanks!

I trust the unit tests about the change of features for the tokio crate :)

@thomastaylor312 thomastaylor312 merged commit 2130b5e into oras-project:main Jan 26, 2023
@lulf lulf deleted the wasm branch January 27, 2023 07:24
thomastaylor312 added a commit that referenced this pull request Mar 2, 2023
Add support for compiling to wasm32 architecture
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants