Add million@2.0.0 benchmark
#1204
Conversation
|
|
||
| (() => { | ||
| new Block( | ||
| stringToDOM( |
There was a problem hiding this comment.
Does this count as too much optimization here?
There was a problem hiding this comment.
Is this code generated by a compiler? (Asking since it's under /src)
There was a problem hiding this comment.
No, it's not. I can rewrite it such that it uses the canonical API instead, do you think that's more aligned with this bench?
There was a problem hiding this comment.
Yeah that would probably be better, I can't imagine people in practice will write code like that.
|
No doubt, it's pretty fast, but looking at the code I'm sure we'll have lots of discussions what flags to add (I propose #772). |
|
I see.. hmm... @aidenybai you can correct me, but it looks like on select you look up the VDOM nodes and then patch them directly here. I agree this verges on #772. Instead of writing code to describe the selection in the view you do an imperative lookup and mutation. |
|
Sounds good, I agree with the #772 flag. Is the best way to add a new flag to open up a PR? |
Removes
unkeyedMillion 1.x implementations.Adds Million 2.x
keyedimplementation with (#801)