SDK types build: calculate required/optional fields from schema #1321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use typedoc types
longzheng
commented
Feb 15, 2024
| @@ -2,12 +2,14 @@ import stringifyObject from 'stringify-object'; | |||
| import { ScryptedInterface, ScryptedInterfaceDescriptor } from "./types.input"; | |||
| import path from 'path'; | |||
| import fs from "fs"; | |||
| import packageJson from "../package.json" | |||
There was a problem hiding this comment.
We can import package.json directly instead of using JSON.parse(fs.readFileSync(
rustyd0g
pushed a commit
to rustyd0g/scrypted
that referenced
this pull request
Feb 17, 2024
* Add tsconfig for sdk/types/src * Get property isOptional from schema Use typedoc types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@koush I noticed you added support for required properties in the
build.tsbut I realised we can actually do this dynamically from the typedoc schema.In the future we can improve the types even further for
function toTypescriptType(type: any): stringandfunction toPythonType(type: any): string {but it was too much trouble so ignoring for now.