Add strict types to sdk #1308
Merged
Add strict types to sdk #1308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
longzheng
commented
Feb 11, 2024
This comment was marked as resolved.
This comment was marked as resolved.
koush
reviewed
Feb 11, 2024
This comment was marked as resolved.
This comment was marked as resolved.
koush
reviewed
Feb 13, 2024
longzheng
commented
Feb 14, 2024
longzheng
commented
Feb 14, 2024
koush
reviewed
Feb 14, 2024
koush
reviewed
Feb 14, 2024
koush
reviewed
Feb 14, 2024
koush
reviewed
Feb 14, 2024
koush
reviewed
Feb 14, 2024
koush
reviewed
Feb 14, 2024
|
getting closer, I added some changes to accommodate some things your change pointed out. |
Use typedoc types
|
I merge in fixes from #1321 so that should be merged first. |
|
merged that, but conflicts on this for some reason |
|
@koush resolved the conflicts |
longzheng
commented
Feb 15, 2024
koush
reviewed
Feb 15, 2024
koush
reviewed
Feb 15, 2024
rustyd0g
pushed a commit
to rustyd0g/scrypted
that referenced
this pull request
Feb 17, 2024
* Enable strict mode * Add @types/node Remove @types/rimraf * Fix `include` path to be actual `src` * Add strict to `sdk` * Assert `getItem` * Fix types in SDK * Refactor SDK function to be type safe * parseValue handle value null or undefined * Fix types tsconfig * Make getDeviceConsole required * Add build-sdk workflow * Set working directory * Assert not undefined * Remove optionals * Undo addScryptedInterfaceProperties, revert to self executing function * Use different type * Make _deviceState private and add ts-ignore * Remove unused function * Remove non-null asserts * Add tsconfig for sdk/types/src * Get property isOptional from schema Use typedoc types * Type fixes * Fix type * Fix type * Revert change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable TypeScript strict for
sdk/typesEnable TypeScript strict strict for
sdkFix various type-related issues
Add
build-sdkGitHub Actions workflow to ensure SDK builds and doesn't have errors