Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle task and application tasks status of "task succeeded but has errors" #1997

Closed
sjd78 opened this issue Jul 3, 2024 · 2 comments · Fixed by #2011
Closed

Handle task and application tasks status of "task succeeded but has errors" #1997

sjd78 opened this issue Jul 3, 2024 · 2 comments · Fixed by #2011
Assignees
@sjd78
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/major Important over the long term, but may not be staffed and/or may need multiple releases to complete. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Milestone
v0.5.0

Comments

@sjd78
Copy link
Member

sjd78 commented Jul 3, 2024

Tasks have terminal states of Canceled, Failed, and Succeeded. In some cases, it is possible for a Task to be Succeeded but also include errors. On the UI, the statues of "Succeeded" and "Succeeded With Errors" need to differentiated.

Task status columns (at least application inventory name column, task manager status column):

  • All other existing statuses remain unchanged
  • Succeeded → Green circle check mark icon with text "Succeeded"
  • SucceededWithErrors → Yellow triangle exclamation icon with text "Succeeded With Errors"

Application inventory analysis column:

  • All other existing statuses remain unchanged
  • Latest task state of SucceededWithErrors can use the Yellow triangle exclamation icon with text "Completed With Errors"
@sjd78 sjd78 added this to the v0.5.0 milestone Jul 3, 2024
@konveyor-ci-bot
Copy link

This issue is currently awaiting triage.
If contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.
The triage/accepted label can be added by org members.

@konveyor-ci-bot konveyor-ci-bot bot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-kind Indicates an issue or PR lacks a `kind/foo` label and requires one. labels Jul 3, 2024
@konveyor-ci-bot konveyor-ci-bot bot added the needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. label Jul 3, 2024
@github-project-automation github-project-automation bot moved this to 🆕 New in Planning Jul 3, 2024
@sjd78
Copy link
Member Author

sjd78 commented Jul 3, 2024

/kind feature
/priority major
/triage accepted

@sjd78 sjd78 moved this from 🆕 New to 🔖 Ready in Planning Jul 3, 2024
@konveyor-ci-bot konveyor-ci-bot bot added kind/feature Categorizes issue or PR as related to a new feature. priority/major Important over the long term, but may not be staffed and/or may need multiple releases to complete. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-kind Indicates an issue or PR lacks a `kind/foo` label and requires one. needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. labels Jul 3, 2024
@sjd78 sjd78 moved this from 🔖 Ready to 🏗 In progress in Planning Jul 9, 2024
@sjd78 sjd78 self-assigned this Jul 9, 2024
sjd78 added a commit to sjd78/tackle2-ui that referenced this issue Jul 12, 2024
@sjd78
Starting work on konveyor#1997
557791d 
Signed-off-by: Scott J Dickerson <sdickers@redhat.com>
@sjd78 sjd78 mentioned this issue Jul 12, 2024
Merged
sjd78 added a commit to sjd78/tackle2-ui that referenced this issue Jul 15, 2024
@sjd78
Starting work on konveyor#1997
69831be 
Signed-off-by: Scott J Dickerson <sdickers@redhat.com>
@jortel jortel mentioned this issue Jul 16, 2024
Merged
jortel added a commit to konveyor/tackle2-hub that referenced this issue Jul 16, 2024
@jortel
✨ Add task dashboard report. (#720)
1d3f382 
Better support succeeded with errors.

closes #725 

needed by: konveyor/tackle2-ui#1997

Example:
GET /tasks/report/dashboard
```
- id: 7
  createUser: admin.noauth
  createTime: 2024-07-15T15:35:53.198405073Z
  name: Daytrader7.1.windup
  kind: analyzer
  addon: analyzer
  state: Succeeded
  application:
    id: 1
    name: Daytrader7
  started: 2024-07-15T15:35:53.514805251Z
  terminated: 2024-07-15T15:39:40.54619695Z
- id: 8
  createTime: 2024-07-15T18:29:25.26836735Z
  name: Daytrader8-
  kind: language-discovery
  addon: language-discovery
  state: Failed
  application:
    id: 2
    name: Daytrader8
  started: 2024-07-15T18:29:25.648121267Z
  terminated: 2024-07-15T18:29:29.798022283Z
  errors: 1
- id: 9
  createTime: 2024-07-15T18:29:25.26883083Z
  name: Daytrader8-
  kind: tech-discovery
  addon: tech-discovery
  state: Failed
  application:
    id: 2
    name: Daytrader8
  started: 2024-07-15T18:29:29.798635671Z
  terminated: 2024-07-15T18:29:32.944556989Z
  errors: 1
```

Signed-off-by: Jeff Ortel <jortel@redhat.com>
sjd78 added a commit to sjd78/tackle2-ui that referenced this issue Jul 16, 2024
@sjd78
Starting work on konveyor#1997
cae184a 
Signed-off-by: Scott J Dickerson <sdickers@redhat.com>
sjd78 added a commit that referenced this issue Jul 16, 2024
@sjd78
✨ Add handling for tasks "Succeeded with errors" in task and applicat…
4182243 
…ion tables (#2011)

### Summary
Resolves: #1997

When a task is succeeded but has attached errors, render task state,
application tasks state and application analysis state with a warning.

### Details of Changes
With this change, hub is not adding a new terminal state, but having a
new terminal state is an easy way to handle things. The task queries
will now evaluate the `state` and `errors` props to determine if
"Succeeded" should be "SucceededWithErrors". This synthetic task status
makes updating all of the UI component much simpler.

To function properly, HUB [Issue
725](konveyor/tackle2-hub#725) / [PR
720](konveyor/tackle2-hub#720) are required.

Changes have also been made to utilize the `/tasks/reports/dashboard`
endpoint to get a much smaller view of tasks when dealing with them in
aggregate.

The application details drawer was refactored to push data fetching
closer to actual use, and to break up a very large component into a
container component with a component dedicated to each tab.

### Screenshots
Application inventory page:
![screenshot-localhost_9000-2024 07
15-18_33_20](https://github.com/user-attachments/assets/b7015ebf-4305-4d6d-a670-5e4fe532981d)

Application tasks popover:
![image](https://github.com/user-attachments/assets/14d4d19e-eaca-4505-88be-d5016da1e70b)

Task Manager page:
![screenshot-localhost_9000-2024 07
15-18_35_15](https://github.com/user-attachments/assets/2547a46a-1fa6-456f-836c-4e59cc0fd074)

---------

Signed-off-by: Scott J Dickerson <sdickers@redhat.com>
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Planning Jul 16, 2024
This was referenced Jul 18, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sjd78 sjd78

Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/major Important over the long term, but may not be staffed and/or may need multiple releases to complete. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
Planning
Status: ✅ Done
Milestone
v0.5.0
Development

Successfully merging a pull request may close this issue.

✨ Add handling for tasks "Succeeded with errors" in task and application tables sjd78/tackle2-ui
1 participant
@sjd78