Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Fetch task collection limited to 500 #725

Closed
1 task done
jortel opened this issue Jul 15, 2024 · 1 comment · Fixed by #720
Closed
1 task done

🐛 Fetch task collection limited to 500 #725

jortel opened this issue Jul 15, 2024 · 1 comment · Fixed by #720
Assignees
@jortel
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/major Important over the long term, but may not be staffed and/or may need multiple releases to complete. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Milestone
v0.5.0

Comments

@jortel
Copy link
Contributor

jortel commented Jul 15, 2024 •
edited
Loading

Is there an existing issue for this?

  • I have searched the existing issues

Konveyor version

0.5

Priority

Blocker

Current Behavior

GET /tasks limited to 500. This is consistent with other Large endpoints but causes difficulties for the UI.
Solution:
Add a new dashboard (report) endpoint: /tasks/report/dashboard.
A task dashboard resource is:

  • id
  • createTime
  • createUser
  • name
  • kind
  • addon
  • state
  • errors (count)
  • application
    • id
    • name
  • started
  • terminated

Filters:

  • kind
  • createUser
  • addon
  • name
  • locator
  • state
  • application.id
  • application.name

Expected Behavior

No response

How Reproducible

Always (Default)

Steps To Reproduce

  1. Cause more than 500 tasks to be created.
  2. UI will error trying to fetch them all.

Environment

- OS:

Anything else?

No response
@jortel jortel added kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 15, 2024
@jortel jortel added this to Planning Jul 15, 2024
@github-project-automation github-project-automation bot moved this to 🆕 New in Planning Jul 15, 2024
@jortel jortel added this to the v0.5.0 milestone Jul 15, 2024
@konveyor-ci-bot
Copy link

This issue is currently awaiting triage.
If contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.
The triage/accepted label can be added by org members.

@konveyor-ci-bot konveyor-ci-bot bot added the needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. label Jul 15, 2024
@jortel jortel self-assigned this Jul 15, 2024
@jortel jortel added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/major Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. labels Jul 15, 2024
@jortel jortel mentioned this issue Jul 15, 2024
Merged
@sjd78 sjd78 mentioned this issue Jul 15, 2024
Merged
@jortel jortel closed this as completed in 1d3f382 Jul 16, 2024
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in Planning Jul 16, 2024
sjd78 added a commit to konveyor/tackle2-ui that referenced this issue Jul 16, 2024
@sjd78
✨ Add handling for tasks "Succeeded with errors" in task and applicat…
4182243 
…ion tables (#2011)

### Summary
Resolves: #1997

When a task is succeeded but has attached errors, render task state,
application tasks state and application analysis state with a warning.

### Details of Changes
With this change, hub is not adding a new terminal state, but having a
new terminal state is an easy way to handle things. The task queries
will now evaluate the `state` and `errors` props to determine if
"Succeeded" should be "SucceededWithErrors". This synthetic task status
makes updating all of the UI component much simpler.

To function properly, HUB [Issue
725](konveyor/tackle2-hub#725) / [PR
720](konveyor/tackle2-hub#720) are required.

Changes have also been made to utilize the `/tasks/reports/dashboard`
endpoint to get a much smaller view of tasks when dealing with them in
aggregate.

The application details drawer was refactored to push data fetching
closer to actual use, and to break up a very large component into a
container component with a component dedicated to each tab.

### Screenshots
Application inventory page:
![screenshot-localhost_9000-2024 07
15-18_33_20](https://github.com/user-attachments/assets/b7015ebf-4305-4d6d-a670-5e4fe532981d)

Application tasks popover:
![image](https://github.com/user-attachments/assets/14d4d19e-eaca-4505-88be-d5016da1e70b)

Task Manager page:
![screenshot-localhost_9000-2024 07
15-18_35_15](https://github.com/user-attachments/assets/2547a46a-1fa6-456f-836c-4e59cc0fd074)

---------

Signed-off-by: Scott J Dickerson <sdickers@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jortel jortel

Labels
kind/bug Categorizes issue or PR as related to a bug. priority/major Important over the long term, but may not be staffed and/or may need multiple releases to complete. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
Planning
Status: ✅ Done
Milestone
v0.5.0
Development

Successfully merging a pull request may close this issue.

✨ Add task dashboard report. jortel/tackle2-hub
1 participant
@jortel