Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👻 Better modeling of SCM and maven. #53

Merged
merged 3 commits into from
Aug 13, 2024
Merged

Conversation

jortel
Copy link
Contributor

@jortel jortel commented Jan 10, 2024

The Remote currently contains a *api.Repository which is good for the SCM repositories but not relevant for Maven. After this is removed, Remote only provides common authentication attributes/operations. This is the only thing SCM and Maven repositories have in common.

@jortel jortel marked this pull request as ready for review January 23, 2024 19:10
@jortel jortel requested a review from dymurray January 24, 2024 16:14
Copy link
Contributor

@dymurray dymurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jortel added 3 commits August 9, 2024 10:59
Signed-off-by: Jeff Ortel <jortel@redhat.com>
Signed-off-by: Jeff Ortel <jortel@redhat.com>
Signed-off-by: Jeff Ortel <jortel@redhat.com>
@jortel jortel merged commit 3153a61 into konveyor:main Aug 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants