Better modeling of SCM and maven.

Signed-off-by: Jeff Ortel <jortel@redhat.com>

repository/factory.go

@@ -20,17 +20,17 @@ func New(destDir string, remote *api.Repository, identities []api.Ref) (r SCM, e
 	switch remote.Kind {
 	case "subversion":
 		r = &Subversion{
-			Path: destDir,
-			Remote: Remote{
-				Repository: remote,
+			Path:   destDir,
+			Remote: *remote,
+			Authenticated: Authenticated{
 				Identities: identities,
 			},
 		}
 	default:
 		r = &Git{
-			Path: destDir,
-			Remote: Remote{
-				Repository: remote,
+			Path:   destDir,
+			Remote: *remote,
+			Authenticated: Authenticated{
 				Identities: identities,
 			},
 		}
@@ -47,14 +47,13 @@ type SCM interface {
 	Commit(files []string, msg string) (err error)
 }
 
-// Remote repository.
-type Remote struct {
-	*api.Repository
+// Authenticated repository.
+type Authenticated struct {
 	Identities []api.Ref
 }
 
 // FindIdentity by kind.
-func (r *Remote) findIdentity(kind string) (matched *api.Identity, found bool, err error) {
+func (r *Authenticated) findIdentity(kind string) (matched *api.Identity, found bool, err error) {
 	for _, ref := range r.Identities {
 		identity, nErr := addon.Identity.Get(ref.ID)
 		if nErr != nil {

repository/git.go

@@ -16,8 +16,9 @@ import (
 
 // Git repository.
 type Git struct {
-	Remote
-	Path string
+	Authenticated
+	Remote api.Repository
+	Path   string
 }
 
 // Validate settings.

repository/subversion.go

@@ -17,8 +17,9 @@ import (
 
 // Subversion repository.
 type Subversion struct {
-	Remote
-	Path string
+	Authenticated
+	Remote api.Repository
+	Path   string
 }
 
 // Validate settings.