👻 Revert 0.4 stuff #86
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The addon is passing non-YAML files in --rules option to the analyzer. For example: when custom targets built with uploaded windup.xml files. This does not seem to hurt anything. The analyzer output mentions that it cannot be parsed as YAML but does not error. Fixing will mainly avoid: confusion; red-herrings while troubleshooting. Signed-off-by: Jeff Ortel <jortel@redhat.com>
upgrade Go 1.20. Replaces gofmt with goimports. Documentation claims it performs the same formatting plus manages/orders imports. Added missing packages in Makefile. Updated the go.mod and ran go mod tidy. closes: konveyor#63 NOT FOR 0.3. --------- Signed-off-by: Jeff Ortel <jortel@redhat.com>
Moving the non system binaries to /usr/local/bin --------- Signed-off-by: Shawn Hurley <shawn@hurley.page>
Signed-off-by: Shawn Hurley <shawn@hurley.page>
Signed-off-by: Shawn Hurley <shawn@hurley.page>
Signed-off-by: Jeff Ortel <jortel@redhat.com>
Latest hub. Fixed in hub addon binding: konveyor/tackle2-hub#629 Signed-off-by: Jeff Ortel <jortel@redhat.com>
dymurray
reviewed
Apr 30, 2024
hack/konveyor-analyzer
Outdated
| @@ -16,7 +16,7 @@ do | |||
| done | |||
|
|
|||
| docker run \ | |||
| --entrypoint /usr/local/bin/konveyor-analyzer \ | |||
| --entrypoint konveyor-analyzer \ | |||
There was a problem hiding this comment.
does this need to be /usr/bin/konveyor-analyzer? Assume it doesn't matter since its in PATH
There was a problem hiding this comment.
This is a hack I created to run the analyzer locally as a command. I don't know if this will work without the path or not. @shawn-hurley made the changes.
There was a problem hiding this comment.
we will see when CI runs
dymurray
reviewed
Apr 30, 2024
…konveyor#80)" This reverts commit 92300c9. Signed-off-by: Jeff Ortel <jortel@redhat.com>
…onveyor#82)" This reverts commit 4ad2bc9. Signed-off-by: Jeff Ortel <jortel@redhat.com>
jortel
force-pushed
the
revert-0.4-stuff
branch
from
2cbca1d to
17d2c83
Compare
shawn-hurley
force-pushed
the
release-0.3
branch
from
d94b0a0 to
d0dbb06
Compare
|
Closing PR, we solved this another way |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.