Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Go 1.20. #63

Closed
jortel opened this issue Nov 15, 2023 · 0 comments · Fixed by #76
Closed

Upgrade Go 1.20. #63

jortel opened this issue Nov 15, 2023 · 0 comments · Fixed by #76
Labels
tech-debt

Comments

@jortel
Copy link
Contributor

jortel commented Nov 15, 2023 •
edited
Loading

Upgrade to Go 1.20.
This will cause a mass reformat. In 1.19 gofmt added a number of pedantic rules.
We'll need to update go.mod and re-run go mod tidy.

Use goimports for import ordering.

Replace interface{} with any.

Run gofmt

run goimports.
@jortel jortel added this to Planning Nov 15, 2023
@github-project-automation github-project-automation bot moved this to 🆕 New in Planning Nov 15, 2023
@jortel jortel moved this from 🆕 New to 📋 Backlog in Planning Nov 15, 2023
@jortel jortel moved this from 📋 Backlog to 🔖 Ready in Planning Jan 23, 2024
@jortel jortel moved this from 🔖 Ready to 🏗 In progress in Planning Jan 24, 2024
@jortel jortel mentioned this issue Jan 24, 2024
Merged
jortel added a commit that referenced this issue Jan 24, 2024
@jortel
👻 Go 1.20 (#76)
db75db5 
upgrade Go 1.20.
Replaces gofmt with goimports. Documentation claims it performs the same
formatting plus manages/orders imports.
Added missing packages in Makefile.
Updated the go.mod and ran go mod tidy.

closes: #63 

NOT FOR 0.3.

---------

Signed-off-by: Jeff Ortel <jortel@redhat.com>
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Planning Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tech-debt
Projects
Planning
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

👻 Go 1.20 jortel/tackle2-addon-analyzer
1 participant
@jortel