✨ Update logging of closed RPC errors

external-providers/java-external-provider/pkg/java_external_provider/service_client.go

@@ -126,7 +126,11 @@ func (p *javaServiceClient) GetAllSymbols(ctx context.Context, query, location s
 	var refs []protocol.WorkspaceSymbol
 	err := p.rpc.Call(ctx, "workspace/executeCommand", wsp, &refs)
 	if err != nil {
-		p.log.Error(err, "unable to ask for tackle rule entry")
+		if jsonrpc2.IsRPCClosed(err) {
+			p.log.Error(err, "connection to the language server is closed, language server is not running")
+		} else {
+			p.log.Error(err, "unable to ask for Konveyor rule entry")
+		}
 	}
 
 	return refs
@@ -167,7 +171,11 @@ func (p *javaServiceClient) GetAllReferences(ctx context.Context, symbol protoco
 	res := []protocol.Location{}
 	err := p.rpc.Call(ctx, "textDocument/references", params, &res)
 	if err != nil {
-		fmt.Printf("Error rpc: %v", err)
+		if jsonrpc2.IsRPCClosed(err) {
+			p.log.Error(err, "connection to the language server is closed, language server is not running")
+		} else {
+			fmt.Printf("Error rpc: %v", err)
+		}
 	}
 	return res
 }
@@ -238,7 +246,11 @@ func (p *javaServiceClient) initialization(ctx context.Context) {
 	var result protocol.InitializeResult
 	for i := 0; i < 10; i++ {
 		if err := p.rpc.Call(ctx, "initialize", params, &result); err != nil {
-			p.log.Error(err, "initialize failed")
+			if jsonrpc2.IsRPCClosed(err) {
+				p.log.Error(err, "connection to the language server is closed, language server is not running")
+			} else {
+				p.log.Error(err, "initialize failed")
+			}
 			continue
 		}
 		break

jsonrpc2/jsonrpc2.go

@@ -145,7 +145,11 @@ func (c *Conn) Call(ctx context.Context, method string, params, result interface
 	}
 	if err != nil {
 		// sending failed, we will never get a response, so don't leave it pending
+		if IsRPCClosed(err) {
+			err = fmt.Errorf("connection to the language server is closed, language server is not running: %w", err)
+		}
 		return err
+
 	}
 	// now wait for the response
 	select {

jsonrpc2/rpcerr.go

@@ -0,0 +1,13 @@
+package jsonrpc2
+
+import (
+	"strings"
+)
+
+var errFileClosed = "file already closed"
+var errBrokenPipe = "broken pipe"
+
+func IsRPCClosed(err error) bool {
+	var errMsg = err.Error()
+	return strings.HasSuffix(errMsg, errFileClosed) || strings.HasSuffix(errMsg, errBrokenPipe)
+}

jsonrpc2_v2/conn.go

@@ -292,6 +292,9 @@ func (c *Connection) Notify(ctx context.Context, method string, params interface
 		attempted = true
 	})
 	if err != nil {
+		if IsRPCClosed(err) {
+			err = fmt.Errorf("connection to the language server is closed, language server is not running: %w", err)
+		}
 		return err
 	}
 
@@ -351,6 +354,9 @@ func (c *Connection) Call(ctx context.Context, method string, params interface{}
 
 	event.Metric(ctx, tag.Started.Of(1))
 	if err := c.write(ctx, call); err != nil {
+		if IsRPCClosed(err) {
+			err = fmt.Errorf("connection to the language server is closed, language server is not running: %w", err)
+		}
 		// Sending failed. We will never get a response, so deliver a fake one if it
 		// wasn't already retired by the connection breaking.
 		c.updateInFlight(func(s *inFlightState) {

jsonrpc2_v2/rpcerr.go

@@ -0,0 +1,13 @@
+package jsonrpc2
+
+import (
+	"strings"
+)
+
+var errFileClosed = "file already closed"
+var errBrokenPipe = "broken pipe"
+
+func IsRPCClosed(err error) bool {
+	var errMsg = err.Error()
+	return strings.HasSuffix(errMsg, errFileClosed) || strings.HasSuffix(errMsg, errBrokenPipe)
+}