✨ Update logging of closed RPC errors

[abrugaro]

Solves #500

[shawn-hurley]

I love the error method big +1 on that.

I wonder if we can add this at the end of the Call and Notify calls in the jsontrpc2_v2 package here:

I am thinking something in the Call and Notify calls here: https://github.com/konveyor/analyzer-lsp/blob/main/jsonrpc2_v2/conn.go#L312

This would allow for other providers to get the benefit if they are using these packages as well?

[abrugaro]

Thanks for your comment @shawn-hurley

In the call method, should I add it here: https://github.com/konveyor/analyzer-lsp/blob/main/jsonrpc2_v2/conn.go#L354 ? and here for Notify: https://github.com/konveyor/analyzer-lsp/blob/main/jsonrpc2_v2/conn.go#L288?

And one more question, should I do the same for the jsonrpc2 (v1) package?

Thanks!!

[shawn-hurley]

Yes those locations look correct to me

and yes if you can add it in v1 as well that would be amazing

[shawn-hurley]

@abrugaro, we are experiencing some issues with the CI system, so while this is a low-risk change that I would normally merge on green, this might take a little longer to get in. I am sorry

[abrugaro]

@abrugaro, we are experiencing some issues with the CI system, so while this is a low-risk change that I would normally merge on green, this might take a little longer to get in. I am sorry

Sure, its my first contribution to this project so I prefer to wait to be sure that everything is ok before merging 😄

[shawn-hurley]

Thank you @abrugaro this is a really helpful change!