Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Fix source decompilation #409

Merged
merged 5 commits into from
Nov 9, 2023
Merged

🐛 Fix source decompilation #409

merged 5 commits into from
Nov 9, 2023

Conversation

jmle
Copy link
Contributor

@jmle jmle commented Nov 7, 2023 •
edited
Loading

  • Only decompile NOT resolved which don't appear in the RESOLVED list.
  • Do not rely on sources classifier
  • Maven to output raw (without colors)
  • Uses fixed version of the maven-dependency-plugin. This is a temporary fix, until we can get the fix into the plugin and use official versions again.

Depends on konveyor/java-analyzer-bundle#81
Fixes #406

jmle and others added 3 commits November 8, 2023 14:19
@jmle @pranavgaikwad
Only decompile NOT resolved which don't appear in the RESOLVED list; …
549d4e7 
…do not rely on sources classifier; maven to output raw (without colors)

Signed-off-by: Juan Manuel Leflet Estrada <jleflete@redhat.com>
@jmle @pranavgaikwad
Use fixed maven-dependency-plugin version
429de30 
Signed-off-by: Juan Manuel Leflet Estrada <jleflete@redhat.com>
@pranavgaikwad
🐛 fix deps parsing
bcd1b44 
Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>
@pranavgaikwad
🐛 add file path prefix to fallback parser
9646624 
Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>
@pranavgaikwad
🐛 fix sha capturing logic
a198e89 
Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>
@pranavgaikwad
Copy link
Contributor

Hey folks, I tested this PR with tackle-testapp and daytrader apps, this fixes the issues once and for all. Since I am the co-author, I'd like someone else to take a look as well.

fabianvf
fabianvf approved these changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@fabianvf fabianvf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pranavgaikwad pranavgaikwad mentioned this pull request Nov 8, 2023
Closed
1 task
@pranavgaikwad pranavgaikwad added do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. and removed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. labels Nov 8, 2023
@jmle jmle merged commit d295615 into konveyor:main Nov 9, 2023
This was referenced Nov 22, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabianvf fabianvf fabianvf approved these changes

@pranavgaikwad pranavgaikwad pranavgaikwad approved these changes

@shawn-hurley shawn-hurley Awaiting requested review from shawn-hurley

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Decompilation of unresolved dependency sources is not working as expected
3 participants
@jmle @pranavgaikwad @fabianvf