Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Decompilation of unresolved dependency sources is not working as expected #406

Closed
1 task done
pranavgaikwad opened this issue Nov 6, 2023 · 1 comment · Fixed by #409 or #414
Closed
1 task done

[BUG] Decompilation of unresolved dependency sources is not working as expected #406

pranavgaikwad opened this issue Nov 6, 2023 · 1 comment · Fixed by #409 or #414
Assignees
@jmle
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/release-blocker Must be staffed and worked in time for the next release.
Milestone
0.3-beta.2

Comments

@pranavgaikwad
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Konveyor version

0.3.0-beta.2

Priority

Critical

Current Behavior

In the tackle-testapp test, when you select cloud-readiness target, the analyzer is supposed to decompile config-utils library which is not being deompiled as expected because there's a bug in reading the dependency:sources output. This causes the local-storage-00001 rule to not match.

Expected Behavior

The issue for rule local-storage-0001 must be matched returning results for matches from config-utils library.

How Reproducible

Always (Default)

Steps To Reproduce

  1. Run analysis for tackle-testapp with the correct maven settings.
  2. Select targets cloud-readiness
  3. Check for issue generated for local-storage-00001 rule with title File System - Java IO

Environment

- **Analyzer Image SHA** 
- **JDTLS  base image SHA**
- **Provider Settings JSON**

Anything else?

No response
@pranavgaikwad pranavgaikwad added kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 6, 2023
@github-project-automation github-project-automation bot moved this to 🆕 New in Planning Nov 6, 2023
@pranavgaikwad pranavgaikwad removed the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Nov 6, 2023
@pranavgaikwad pranavgaikwad moved this from 🆕 New to 🏗 In progress in Planning Nov 6, 2023
@jmle jmle mentioned this issue Nov 8, 2023
Merged
@pranavgaikwad pranavgaikwad added the priority/release-blocker Must be staffed and worked in time for the next release. label Nov 8, 2023
@pranavgaikwad pranavgaikwad added this to the 0.3-beta.2 milestone Nov 8, 2023
@jmle jmle closed this as completed in #409 Nov 9, 2023
jmle added a commit that referenced this issue Nov 9, 2023
@jmle @pranavgaikwad
🐛 Fix source decompilation (#409)
d295615 
- Only decompile NOT resolved which don't appear in the RESOLVED list.
- Do not rely on sources classifier
- Maven to output raw (without colors)
- Uses fixed version of the maven-dependency-plugin. This is a temporary
fix, until we can get the fix into the plugin and use official versions
again.

Depends on konveyor/java-analyzer-bundle#81
Fixes #406

---------

Signed-off-by: Juan Manuel Leflet Estrada <jleflete@redhat.com>
Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>
Co-authored-by: Pranav Gaikwad <pgaikwad@redhat.com>
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Planning Nov 9, 2023
@pranavgaikwad pranavgaikwad reopened this Nov 9, 2023
@pranavgaikwad
Copy link
Contributor Author

This is still not fixed in some scenarios :(

@pranavgaikwad pranavgaikwad mentioned this issue Nov 9, 2023
Merged
pranavgaikwad added a commit that referenced this issue Nov 10, 2023
@pranavgaikwad
🐛 Also download deps prior to downloading sources (#414)
16bc5b1 
Fixes #406

Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmle jmle

Labels
kind/bug Categorizes issue or PR as related to a bug. priority/release-blocker Must be staffed and worked in time for the next release.
Projects
Planning
Status: ✅ Done
Milestone
0.3-beta.2
2 participants
@jmle @pranavgaikwad