Configure pipeline-migration-tool run for tekton manager

[tkdchen]

STONEBLD-2824

Executable script pipeline-migration-tool is available from the Mintmaker image.

This change works with konflux-ci/mintmaker-renovate-image#85 together.

[gnaponie]

Gotcha. So I'm fine with this as change as it is +1

[FernandesMF]

Looks good to me as well!
Edit: the point Riley brought up is very important, and it hadn't occurred to me before.

[qixiang]

/retest

re-trigger the test to check if the old buildah task can pass EC checks.

The point that Riley brought up is very important.

[tkdchen]

Hi team, the issue has been addressed. PTAL.

[staticf0x]

This doesn't unfortunately work, because the {{{ toJSON upgrades }}} contains apostrophes and produces

Command failed: pipeline-migration-tool --renovate-upgrades ' ...
/bin/sh: -c: line 1: syntax error near unexpected token `('
...

would it be possible to escape the apostrophes or use encodeBase64 and modify the pipeline-migration-tool?

[tkdchen]

This doesn't unfortunately work, because the {{{ toJSON upgrades }}} contains apostrophes and produces

Command failed: pipeline-migration-tool --renovate-upgrades ' ...
/bin/sh: -c: line 1: syntax error near unexpected token `('
...

would it be possible to escape the apostrophes or use encodeBase64 and modify the pipeline-migration-tool?

@staticf0x How did you run the Mintmaker and get this failure? I haven't seen it happened during my test that uses a Mintmaker image with this command.

[staticf0x]

Have you used the MintMaker default config? https://github.com/konflux-ci/mintmaker/blob/main/config/renovate/renovate.json it's loaded on server side and used as RENOVATE_CONFIG_FILE. It contains apostrophes in https://github.com/konflux-ci/mintmaker/blob/main/config/renovate/renovate.json#L92

[tkdchen]

Have you used the MintMaker default config? https://github.com/konflux-ci/mintmaker/blob/main/config/renovate/renovate.json it's loaded on server side and used as RENOVATE_CONFIG_FILE. It contains apostrophes in https://github.com/konflux-ci/mintmaker/blob/main/config/renovate/renovate.json#L92

Yes. I've been using my topic branch https://github.com/tkdchen/mintmaker/commits/test-STONEBLD-2824-configure-pmt/ that is based on the changes within this PR.

[tkdchen]

@staticf0x PTAL

[staticf0x]

With these commas it works for me

[staticf0x]

@tkdchen do you have any performance measurements of the pipeline-migration-tool? In my test, I had 14 upgrades, which resulted in 255 calls to fetch_migration_file, and the total run time was 7 - 9 minutes on my machine (most of it is network bound). This can be a huge issue for MintMaker, all Tekton upgrades happen on Saturday after 5 AM UTC and we have ~1000 repos to run on, unfortunately without any way to cache the results between repos.