Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install pipeline-migration-tool #85

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Install pipeline-migration-tool #85

merged 1 commit into from
Jan 14, 2025

Conversation

tkdchen
Copy link
Contributor

@tkdchen tkdchen commented Jan 9, 2025 •
edited
Loading

STONEBLD-2824

This change is part of the EPIC STONEBLD-2712.

@tkdchen tkdchen mentioned this pull request Jan 9, 2025
Open
@staticf0x
Copy link
Collaborator

Is it possible to install using pipx? We already have that in the image and it would be better managed by that tool instead of creating a custom venv and modifying PATH.

@tkdchen tkdchen force-pushed the STONEBLD-2824-configure-pmt branch from 8e6814b to e181144 Compare January 9, 2025 10:13
@tkdchen
Copy link
Contributor Author

tkdchen commented Jan 9, 2025

Is it possible to install using pipx? We already have that in the image and it would be better managed by that tool instead of creating a custom venv and modifying PATH.

Updated.

staticf0x
staticf0x reviewed Jan 9, 2025
View reviewed changes
Dockerfile Outdated
@@ -114,4 +114,6 @@ USER root
RUN pip3 install jsonschema PyYaml productmd requests && pip3 install --no-dependencies . && pip3 cache purge
USER 1001

RUN python3.12 -m pipx install --pip-args='--no-cache-dir' git+https://github.com/konflux-ci/pipeline-migration-tool.git
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I meant if you could add it to line 88:
RUN pipx install --python python3.12 poetry pdm pipenv hashin uv hatch pip-tools git+https://github.com/konflux-ci/pipeline-migration-tool.git && rm -fr ~/.cache/pipx && pip3.12 cache purge

and then remove the change in PATH

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated. Any idea about the EC failures?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it might be the current outage, let's wait a bit.

@tkdchen tkdchen force-pushed the STONEBLD-2824-configure-pmt branch 2 times, most recently from 0b54246 to 3df114e Compare January 9, 2025 12:47
@staticf0x
Copy link
Collaborator

/retest

1 similar comment
@tkdchen
Copy link
Contributor Author

tkdchen commented Jan 13, 2025

/retest

@staticf0x
Copy link
Collaborator

We're investigating the EC failure as it seems this repo is not the only one affected. I'll get back to this when I know more.

@qixiang
Copy link
Collaborator

qixiang commented Jan 13, 2025

EC issue has been fixed, it would be better to rebase your PR (we updated all tasks in #84) in case there are some outdated tasks in this repo.

@tkdchen
Install pipeline-migration-tool
f6006e7 
STONEBLD-2824

This change is part of the EPIC STONEBLD-2712.
@tkdchen tkdchen force-pushed the STONEBLD-2824-configure-pmt branch from 3df114e to f6006e7 Compare January 14, 2025 02:56
@staticf0x staticf0x merged commit f40a176 into konflux-ci:main Jan 14, 2025
2 checks passed
@tkdchen tkdchen deleted the STONEBLD-2824-configure-pmt branch January 17, 2025 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@staticf0x staticf0x staticf0x approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tkdchen @staticf0x @qixiang