Cherry-pick Kokkos_ArithTraits.hpp from #927 #959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I considered cherry-picking the whole pull request but it seems like the change in the unit test structure isn't part of the last release which would make this pretty ugly. |
|
ah we haven't moved arith traits over yet I guess. |
|
@lucbv shall I merge this into the release-candidate-3.4.1 branch, or do you prefer any additional changes come along in addition to the cherry-pick? |
|
@ndellingwood let's go with the cherry picking |
lucbv
approved these changes
May 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests cherry-picks d5f0d7e from #927. The fixes there are needed for trilinos/Trilinos#9086.