Enable SYCL tests #927

masterleinad · 2021-04-05T17:21:34Z

I only fixed the places in src/Kokkos_ArithTraits that were necessary for running the test with the SYCL backend successfully. Using https://github.com/kokkos/kokkos/blob/develop/core/src/Kokkos_MathematicalFunctions.hpp would probably make most of it redundant.
We use KOKKOS_IMPL_DO_NOT_USE_PRINTF internally to work around printf not being directly available with SYCL. The function is not supposed to be used outside the Kokkos since we would want to remove it at any time when there is proper compiler support. I nevertheless used it here. Let me know if you want the printfs to be disabled instead.
Some failing tests are still disabled. I haven't looked too hard into it.

kokkos-devops-admin · 2021-04-05T17:25:05Z

Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
WARNING: NO REVIEWERS HAVE BEEN REQUESTED FOR THIS PULL REQUEST!

lucbv · 2021-04-05T20:25:56Z

@masterleinad I feel sorry you had to do that, I am working on PR #906 to avoid creating all the *.cpp per backend.
Are you in a rush to have this merged in or can you wait a bit on the other PR? The refactor will require only one .cpp (or maybe one per component) which will be more manageable...

masterleinad · 2021-04-05T20:40:21Z

Are you in a rush to have this merged in or can you wait a bit on the other PR? The refactor will require only one .cpp (or maybe one per component) which will be more manageable...

No, no rush here. Actually, it wasn't too bad. Just copying the files from Cuda and doing some renaming via regexes. 🙂

kokkos-devops-admin · 2021-04-06T13:29:38Z

Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
NO REVIEWS HAVE BEEN PERFORMED ON THIS PULL REQUEST!

lucbv · 2021-04-23T05:04:06Z

@masterleinad the refactor of the unit-tests has been merged in develop and will lead require some re-write.
It should not take much time, although new pre-processor guards will be needed in some unit-tests headers...

masterleinad · 2021-04-23T16:20:48Z

@lucbv I rebased and removed the test files that are auto-generated now.

kokkos-devops-admin · 2021-04-23T16:23:18Z

Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
NO REVIEWS HAVE BEEN PERFORMED ON THIS PULL REQUEST!

lucbv

This is fine in general but I do no like the idea of disabling some of the TeamVector tests without having a tracking mechanism.
You can disable the whole batched_sycl test, people will clearly know that there is an issue in there...
You can also open an issue for that but I am not sure if this the safest approach?

unit_test/CMakeLists.txt

unit_test/sycl/Test_SYCL_Batched.cpp

kokkos-devops-admin · 2021-04-23T18:44:27Z

Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
THE LAST COMMIT TO THIS PULL REQUEST HAS BEEN REVIEWED, BUT NOT ACCEPTED OR REQUIRES CHANGES

kokkos-devops-admin · 2021-04-23T19:08:30Z

Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
THE LAST COMMIT TO THIS PULL REQUEST HAS NOT BEEN REVIEWED YET!

masterleinad · 2021-04-23T19:19:49Z

This is fine in general but I do no like the idea of disabling some of the TeamVector tests without having a tracking mechanism.
You can disable the whole batched_sycl test, people will clearly know that there is an issue in there...
You can also open an issue for that but I am not sure if this the safest approach?

If I disable all categories in which failing tests appear, then I'm left with common_sycl. You can always find tests that are problematic by searching for FIXME_SYCL.
I mostly care about having the test infrastructure in place. Getting all the tests passing can be done incrementally IMHO. That being said just let me know what you want me to do.

kokkos-devops-admin · 2021-04-26T20:52:47Z

Status Flag 'Pull Request AutoTester' - User Requested Retest - Label AT: RETEST will be reset after testing.

kokkos-devops-admin · 2021-04-27T20:52:48Z

Status Flag 'Pull Request AutoTester' - User Requested Retest - Label AT: RETEST will be reset after testing.

lucbv

OK, I will open an issue with the list of tests failing but that should be fine

kokkos-devops-admin · 2021-04-27T21:07:53Z

Status Flag 'Pre-Test Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ lucbv ]!

kokkos-devops-admin · 2021-04-27T21:11:22Z

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: KokkosKernels_PullRequest_GCC720

Build Num: 194
Status: STARTED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	sycl_add_tests
KOKKOSKERNELS_SOURCE_REPO	https://github.com/masterleinad/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`315327d`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`90970cc`
PULLREQUESTNUM	927
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_GCC720

Build Num: 187
Status: STARTED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	sycl_add_tests
KOKKOSKERNELS_SOURCE_REPO	https://github.com/masterleinad/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`315327d`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`90970cc`
PULLREQUESTNUM	927
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_INTEL18

Build Num: 173
Status: STARTED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	sycl_add_tests
KOKKOSKERNELS_SOURCE_REPO	https://github.com/masterleinad/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`315327d`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`90970cc`
PULLREQUESTNUM	927
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_GCC720_Light

Build Num: 207
Status: STARTED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	sycl_add_tests
KOKKOSKERNELS_SOURCE_REPO	https://github.com/masterleinad/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`315327d`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`90970cc`
PULLREQUESTNUM	927
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_CUDA10

Build Num: 171
Status: STARTED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	sycl_add_tests
KOKKOSKERNELS_SOURCE_REPO	https://github.com/masterleinad/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`315327d`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`90970cc`
PULLREQUESTNUM	927
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_CUDA9

Build Num: 168
Status: STARTED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	sycl_add_tests
KOKKOSKERNELS_SOURCE_REPO	https://github.com/masterleinad/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`315327d`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`90970cc`
PULLREQUESTNUM	927
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_GCC720_GCC740

Build Num: 166
Status: STARTED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	sycl_add_tests
KOKKOSKERNELS_SOURCE_REPO	https://github.com/masterleinad/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`315327d`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`90970cc`
PULLREQUESTNUM	927
TEST_REPO_ALIAS	KOKKOSKERNELS

Using Repos:

Repo: KOKKOSKERNELS (masterleinad/kokkos-kernels)

Pull Request Author: masterleinad

kokkos-devops-admin · 2021-04-27T21:47:56Z

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: KokkosKernels_PullRequest_GCC720

Build Num: 194
Status: PASSED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	sycl_add_tests
KOKKOSKERNELS_SOURCE_REPO	https://github.com/masterleinad/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`315327d`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`90970cc`
PULLREQUESTNUM	927
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_GCC720

Build Num: 187
Status: PASSED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	sycl_add_tests
KOKKOSKERNELS_SOURCE_REPO	https://github.com/masterleinad/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`315327d`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`90970cc`
PULLREQUESTNUM	927
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_INTEL18

Build Num: 173
Status: PASSED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	sycl_add_tests
KOKKOSKERNELS_SOURCE_REPO	https://github.com/masterleinad/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`315327d`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`90970cc`
PULLREQUESTNUM	927
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_GCC720_Light

Build Num: 207
Status: PASSED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	sycl_add_tests
KOKKOSKERNELS_SOURCE_REPO	https://github.com/masterleinad/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`315327d`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`90970cc`
PULLREQUESTNUM	927
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_CUDA10

Build Num: 171
Status: PASSED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	sycl_add_tests
KOKKOSKERNELS_SOURCE_REPO	https://github.com/masterleinad/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`315327d`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`90970cc`
PULLREQUESTNUM	927
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_CUDA9

Build Num: 168
Status: PASSED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	sycl_add_tests
KOKKOSKERNELS_SOURCE_REPO	https://github.com/masterleinad/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`315327d`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`90970cc`
PULLREQUESTNUM	927
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_GCC720_GCC740

Build Num: 166
Status: PASSED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	sycl_add_tests
KOKKOSKERNELS_SOURCE_REPO	https://github.com/masterleinad/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`315327d`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`90970cc`
PULLREQUESTNUM	927
TEST_REPO_ALIAS	KOKKOSKERNELS

kokkos-devops-admin · 2021-04-27T21:48:14Z

Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ lucbv ]!

kokkos-devops-admin · 2021-04-27T21:48:21Z

Status Flag 'Pull Request AutoTester' - Pull Request MUST BE MERGED MANUALLY BY Project Team - This Repo does not support Automerge

masterleinad · 2021-05-03T22:41:44Z

We will need this one for trilinos/Trilinos#9086.

Cherry-pick Kokkos_ArithTraits.hpp from #927

lucbv self-requested a review April 6, 2021 13:28

masterleinad added 6 commits April 23, 2021 13:16

Use namespace sycl in src/Kokkos_ArithTraits.hpp

d5f0d7e

KOKKOS_IMPL_DO_NOT_USE_PRINTF workaround

7decfad

Disable failing tests

097f746

Enable SYCL tests

d8aa49a

Adapt SYCL test files

96c8aa8

Disable failing tests

6741794

masterleinad force-pushed the sycl_add_tests branch from 85e3f72 to 6741794 Compare April 23, 2021 16:20

lucbv requested changes Apr 23, 2021

View reviewed changes

Address review comments

06fce69

Merge branch 'develop' into sycl_add_tests

315327d

lucbv added the AT: RETEST Have this PR retested. label Apr 26, 2021

lucbv approved these changes Apr 27, 2021

View reviewed changes

kokkos-devops-admin removed the AT: RETEST Have this PR retested. label Apr 27, 2021

lucbv merged commit 54e4213 into kokkos:develop Apr 27, 2021

masterleinad mentioned this pull request May 3, 2021

Tpetra: Allow enabling SYCL backend in Tpetra trilinos/Trilinos#9086

Merged

masterleinad deleted the sycl_add_tests branch May 3, 2021 22:39

masterleinad mentioned this pull request May 6, 2021

Cherry-pick Kokkos_ArithTraits.hpp from #927 #959

Merged

ndellingwood added a commit that referenced this pull request May 13, 2021

Merge pull request #959 from masterleinad/take_over_sycl_pr_927

e00dd52

Cherry-pick Kokkos_ArithTraits.hpp from #927

ndellingwood added the patch-release-cherry-pick label May 19, 2021

kokkos-devops-admin mentioned this pull request Sep 26, 2023

Common: remove half and bhalf implementations #1981

Merged

Enable SYCL tests #927

Enable SYCL tests #927

Conversation

masterleinad commented Apr 5, 2021

kokkos-devops-admin commented Apr 5, 2021

lucbv commented Apr 5, 2021

masterleinad commented Apr 5, 2021

kokkos-devops-admin commented Apr 6, 2021

lucbv commented Apr 23, 2021

masterleinad commented Apr 23, 2021

kokkos-devops-admin commented Apr 23, 2021

lucbv left a comment

Choose a reason for hiding this comment

kokkos-devops-admin commented Apr 23, 2021

kokkos-devops-admin commented Apr 23, 2021

masterleinad commented Apr 23, 2021

kokkos-devops-admin commented Apr 26, 2021

kokkos-devops-admin commented Apr 27, 2021

lucbv left a comment

Choose a reason for hiding this comment

kokkos-devops-admin commented Apr 27, 2021

kokkos-devops-admin commented Apr 27, 2021

Build Information

Test Name: KokkosKernels_PullRequest_GCC720

Jenkins Parameters

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_GCC720

Jenkins Parameters

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_INTEL18

Jenkins Parameters

Build Information

Test Name: KokkosKernels_PullRequest_GCC720_Light

Jenkins Parameters

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_CUDA10

Jenkins Parameters

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_CUDA9

Jenkins Parameters

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_GCC720_GCC740

Jenkins Parameters

Using Repos:

kokkos-devops-admin commented Apr 27, 2021

Build Information

Test Name: KokkosKernels_PullRequest_GCC720

Jenkins Parameters

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_GCC720

Jenkins Parameters

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_INTEL18

Jenkins Parameters

Build Information

Test Name: KokkosKernels_PullRequest_GCC720_Light

Jenkins Parameters

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_CUDA10

Jenkins Parameters

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_CUDA9

Jenkins Parameters

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_GCC720_GCC740

Jenkins Parameters

kokkos-devops-admin commented Apr 27, 2021

kokkos-devops-admin commented Apr 27, 2021

masterleinad commented May 3, 2021