Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "module purge" to reproducer reload_modules.sh #718

Merged
merged 1 commit into from
May 4, 2020
Merged

Add "module purge" to reproducer reload_modules.sh #718

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions scripts/cm_test_all_sandia
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1142,6 +1142,7 @@ single_build_and_test() {
then
echo " $MODULE_ENVIRONMENT" &>> reload_modules.sh
fi
echo " module purge" &>> reload_modules.sh
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brian-kelley shouldn't this be placed before the $MODULE_ENVIRONMENT call? Otherwise I think this will blow away modules for some of the systems.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ndellingwood Are you concerned thatpurge will undo commands in $MODULE_ENVIRONMENT? I was worried about that too, but before my changes (before Apr 28) the script also did the machine-specific setup once and then purged before each build.

sems-env is the first in the list of modules for the builds that need it, and I just made sure that module use isn't undone by purge.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for checking, merge when you're ready

echo " module load $compiler_modules_list" &>> reload_modules.sh
echo "" &>> reload_modules.sh
chmod +x reload_modules.sh
Expand Down