Add "module purge" to reproducer reload_modules.sh #718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndellingwood
reviewed
May 4, 2020
| @@ -1142,6 +1142,7 @@ single_build_and_test() { | |||
| then | |||
| echo " $MODULE_ENVIRONMENT" &>> reload_modules.sh | |||
| fi | |||
| echo " module purge" &>> reload_modules.sh | |||
There was a problem hiding this comment.
@brian-kelley shouldn't this be placed before the $MODULE_ENVIRONMENT call? Otherwise I think this will blow away modules for some of the systems.
There was a problem hiding this comment.
@ndellingwood Are you concerned thatpurge will undo commands in $MODULE_ENVIRONMENT? I was worried about that too, but before my changes (before Apr 28) the script also did the machine-specific setup once and then purged before each build.
sems-env is the first in the list of modules for the builds that need it, and I just made sure that module use isn't undone by purge.
There was a problem hiding this comment.
Thanks for checking, merge when you're ready
ndellingwood
approved these changes
May 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a one-line change to cm_test_all_sandia. It fixes the reproducer instructions for bowman, which was saying "module intel/18... conflicts with loaded module...". This matches the actual behavior of the testing script, which purges module before each build.