-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#415: API-alphabetical from md to rst #417
#415: API-alphabetical from md to rst #417
Conversation
yes |
please make sure ALL links are correct - I will make a pass too, but just want to make sure you do that too |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we can do the Subview thing this way. Otherwise looks good.
@antoinemeyer5 can you please describe the solution so that it is clear what is going on |
There are two ways to create internal links with rst: (1) simple link: The first solution (1) is simple, but makes no difference between the link name and its display. Internally, the link is called Subview and the display clickable by the user is Subview. In our case, there were several links with the same internal name, so we had a duplication warning. (2) more customizable link: .. declaration
.. |SubviewType| replace:: Subview
.. _SubviewType: core/view/Subview_type.html
.. use
|SubviewType|_ This second solution (2) does the same thing and display, but differentiates between:
Thanks to this, you can converse with the desired display and avoid internal duplication. You must always be careful not to have another link in this file whose name is SubviewType, otherwise the duplication warning will return. With this solution, it's much simpler to have internal link names with a certain shape and a different display. This separates rst's internal logic from the user's display. |
ok makes sense to me |
BTW - In the future, we could potentially rely on the index since it's auto-generated |
sounds a good idea |
Notes
Screenshots