Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

verify that doc builds warnings-free when 417 is fixed #433

Closed
fnrizzi opened this issue Jul 5, 2023 · 5 comments
Closed

verify that doc builds warnings-free when 417 is fixed #433

fnrizzi opened this issue Jul 5, 2023 · 5 comments
Assignees

Comments

@fnrizzi
Copy link
Collaborator

fnrizzi commented Jul 5, 2023

according to #420, once #417 is merged, the doc should build without warnings if using all the packages listed in the requiremtns .

We should verify this is the case and report any problems or unexpected behavior.

@antoinemeyer5
Copy link
Collaborator

I have checked @fnrizzi and with #417, the doc build without any warnings.

@fnrizzi
Copy link
Collaborator Author

fnrizzi commented Jul 5, 2023

i still get these:

/kokkos-core-wiki/docs/source/ProgrammingGuide/Atomic-Operations.md:85: WARNING: 'myst' cross-reference target not found: '../API/core/atomics/atomic_op_fetch.md' [myst.xref_missing]
/kokkos-core-wiki/docs/source/ProgrammingGuide/HierarchicalParallelism.md:266: WARNING: 'myst' cross-reference target not found: '../API/core/policies/TeamThreadRange.md' [myst.xref_missing]
/kokkos-core-wiki/docs/source/usecases/MDRangePolicy.md:91: WARNING: 'myst' cross-reference target not found: '../API/core/view/layoutLeft.md' [myst.xref_missing]

@antoinemeyer5
Copy link
Collaborator

antoinemeyer5 commented Jul 6, 2023

i still get these:

/kokkos-core-wiki/docs/source/ProgrammingGuide/Atomic-Operations.md:85: WARNING: 'myst' cross-reference target not found: '../API/core/atomics/atomic_op_fetch.md' [myst.xref_missing]
/kokkos-core-wiki/docs/source/ProgrammingGuide/HierarchicalParallelism.md:266: WARNING: 'myst' cross-reference target not found: '../API/core/policies/TeamThreadRange.md' [myst.xref_missing]
/kokkos-core-wiki/docs/source/usecases/MDRangePolicy.md:91: WARNING: 'myst' cross-reference target not found: '../API/core/view/layoutLeft.md' [myst.xref_missing]

I confirm this error.

Fix here : #435

However, it does not appear in the CI here: https://github.com/kokkos/kokkos-core-wiki/actions/runs/5464124037/jobs/9945729283

I need to find out why I have missed thoses warnings.

Do you have a idea or specific configuration @fnrizzi ?

@fnrizzi
Copy link
Collaborator Author

fnrizzi commented Jul 6, 2023

However, it does not appear in the CI here: https://github.com/kokkos/kokkos-core-wiki/actions/runs/5464124037/jobs/9945729283

it says build finished with problems, 19 warnings.

/home/runner/work/kokkos-core-wiki/kokkos-core-wiki/docs/source/API/alphabetical.md:51: WARNING: 'myst' reference target not found: Cuda
/home/runner/work/kokkos-core-wiki/kokkos-core-wiki/docs/source/API/alphabetical.md:52: WARNING: 'myst' reference target not found: CudaSpace
/home/runner/work/kokkos-core-wiki/kokkos-core-wiki/docs/source/API/alphabetical.md:53: WARNING: 'myst' reference target not found: CudaUVMSpace
/home/runner/work/kokkos-core-wiki/kokkos-core-wiki/docs/source/API/alphabetical.md:54: WARNING: 'myst' reference target not found: CudaHostPinnedSpace
/home/runner/work/kokkos-core-wiki/kokkos-core-wiki/docs/source/API/alphabetical.md:57: WARNING: 'myst' reference target not found: ExecutionSpaceConcept
/home/runner/work/kokkos-core-wiki/kokkos-core-wiki/docs/source/API/alphabetical.md:60: WARNING: 'myst' reference target not found: HostSpace
/home/runner/work/kokkos-core-wiki/kokkos-core-wiki/docs/source/API/alphabetical.md:61: WARNING: 'myst' reference target not found: HPX
/home/runner/work/kokkos-core-wiki/kokkos-core-wiki/docs/source/API/alphabetical.md:65: WARNING: 'myst' reference target not found: is_array_layout
/home/runner/work/kokkos-core-wiki/kokkos-core-wiki/docs/source/API/alphabetical.md:66: WARNING: 'myst' reference target not found: is_execution_policy
/home/runner/work/kokkos-core-wiki/kokkos-core-wiki/docs/source/API/alphabetical.md:67: WARNING: 'myst' reference target not found: ExecutionSpaceConcept
/home/runner/work/kokkos-core-wiki/kokkos-core-wiki/docs/source/API/alphabetical.md:68: WARNING: 'myst' reference target not found: is_memory_space
/home/runner/work/kokkos-core-wiki/kokkos-core-wiki/docs/source/API/alphabetical.md:68: WARNING: 'myst' reference target not found: MemorySpaceConcept
/home/runner/work/kokkos-core-wiki/kokkos-core-wiki/docs/source/API/alphabetical.md:69: WARNING: 'myst' reference target not found: is_memory_traits
/home/runner/work/kokkos-core-wiki/kokkos-core-wiki/docs/source/API/alphabetical.md:70: WARNING: 'myst' reference target not found: is_reducer
/home/runner/work/kokkos-core-wiki/kokkos-core-wiki/docs/source/API/alphabetical.md:71: WARNING: 'myst' reference target not found: is_space
/home/runner/work/kokkos-core-wiki/kokkos-core-wiki/docs/source/API/alphabetical.md:83: WARNING: 'myst' reference target not found: MemorySpaceConcept
/home/runner/work/kokkos-core-wiki/kokkos-core-wiki/docs/source/API/alphabetical.md:88: WARNING: 'myst' reference target not found: OpenMP
/home/runner/work/kokkos-core-wiki/kokkos-core-wiki/docs/source/API/alphabetical.md:89: WARNING: 'myst' reference target not found: OpenMPTarget
/home/runner/work/kokkos-core-wiki/kokkos-core-wiki/docs/source/API/alphabetical.md:105: WARNING: 'myst' reference target not found: Serial

nevermind all alphabetical

@fnrizzi
Copy link
Collaborator Author

fnrizzi commented Jul 6, 2023

Do you have a idea or specific configuration @fnrizzi ?

if you tell me how i find out the configation i am happy to share it

fnrizzi added a commit that referenced this issue Jul 6, 2023
#433 : Fix last warnings to build warnings-free
@fnrizzi fnrizzi closed this as completed Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants