Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀 release new squid version #8931

Closed
wants to merge 4 commits into from

Conversation

roiLeo
Copy link
Contributor

@roiLeo roiLeo commented Jan 10, 2024

may @prury check if data is good?

⚠️ don't merge this, will set indexer to production once tested

Copy link

netlify bot commented Jan 10, 2024

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit e3ab3fa
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/659e842c9ea62a000876b6ab
😎 Deploy Preview https://deploy-preview-8931--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

reviewpad bot commented Jan 10, 2024

AI-Generated Summary: This pull request includes changes in the 'indexers.ts' file of the project. There are updates to the URL endpoints assigned for 'ahk' and 'ahp' within the INDEXERS constant. The old links have been commented out for reference, and the new links for 'ahk' and 'ahp' point to different paths within 'squid.subsquid.io'. No other files were altered in this commit.

@reviewpad reviewpad bot added the small Pull request is small label Jan 10, 2024
Copy link
Contributor

reviewpad bot commented Jan 10, 2024

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

@roiLeo roiLeo added the A-tests label Jan 10, 2024
@roiLeo
Copy link
Contributor Author

roiLeo commented Jan 10, 2024

@yangwao blocked?

Copy link

codeclimate bot commented Jan 10, 2024

Code Climate has analyzed commit e3ab3fa and detected 0 issues on this pull request.

View more on Code Climate.

Copy link

sonarcloud bot commented Jan 10, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.5% Duplication on New Code

See analysis details on SonarCloud

@prury
Copy link
Member

prury commented Jan 10, 2024

@roiLeo it does solve the problem, I'm performing an overall check to see if there's any other problem

https://canary.kodadot.xyz/ahk/gallery/276-33
https://deploy-preview-8931--koda-canary.netlify.app/ahk/gallery/276-33

@roiLeo
Copy link
Contributor Author

roiLeo commented Jan 10, 2024

@roiLeo it does solve the problem, I'm performing an overall check to see if there's any other problem

should solve #8675 & #8839 too

@prury
Copy link
Member

prury commented Jan 10, 2024

@roiLeo it does solve the problem, I'm performing an overall check to see if there's any other problem

should solve #8675 & #8839 too

it does

@prury
Copy link
Member

prury commented Jan 10, 2024

my brain feels like smashed potato today, but i found something:

royalties.mp4

@roiLeo
Copy link
Contributor Author

roiLeo commented Jan 10, 2024

my brain feels like smashed potato today

potato

but i found something:

yeah I think we removed royalties in kodadot/stick#161, idk how it will be handled after that

maybe at collection level? ping @vikiival

@vikiival
Copy link
Member

We can revert them cc @yangwao

@yangwao
Copy link
Member

yangwao commented Jan 10, 2024

Seems floor prices works well?

image

@prury
Copy link
Member

prury commented Jan 10, 2024

Seems floor prices works well?

yes, but check comment about royalties #8931 (comment)

@vikiival
Copy link
Member

yes, but check comment about royalties

Royalties will be back
kodadot/stick#183

@yangwao
Copy link
Member

yangwao commented Jan 11, 2024

can it go with this release?
cc @prury

@vikiival
Copy link
Member

can it go with this release?

Screenshot 2024-01-11 at 13 21 47

@prury
Copy link
Member

prury commented Jan 11, 2024

yes, but check comment about royalties

Royalties will be back kodadot/stick#183

nice, working!

@roiLeo
Copy link
Contributor Author

roiLeo commented Jan 11, 2024

nice, working!

Thanks! closing it then

@roiLeo roiLeo deleted the chore/deploy/indexer branch January 16, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tests small Pull request is small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants