Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove royalties #161

Closed
vikiival opened this issue Dec 17, 2023 · 2 comments
Closed

Remove royalties #161

vikiival opened this issue Dec 17, 2023 · 2 comments

Comments

@vikiival
Copy link
Member

Describe the feature

We have agreed with @yangwao that royalties cause more issues on frontend than actual value

Expected outcome

Just comment all logic in setAttribute.

Reference
Have you seen it somewhere? Share a link/screenshot

Additional context

Cc @daiagi or @roiLeo if can pick it up
@yangwao
Copy link
Member

yangwao commented Dec 17, 2023 •
edited
Loading

yup, seems it shutdown whole trading on top of collection, wreck whole drop experience with volume 0

@roiLeo roiLeo mentioned this issue Dec 17, 2023
Merged
@vikiival
Copy link
Member Author

Closed in #162

@roiLeo roiLeo mentioned this issue Jan 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yangwao @vikiival