Skip to content

Commit

Permalink
added an explanation why DynamicOpentracingHttpTracer has been disabl…
Browse files Browse the repository at this point in the history
…ed (maistra#5)
  • Loading branch information
Dmitri Dolguikh authored Feb 28, 2020
1 parent 7e50506 commit e6e28d9
Showing 1 changed file with 8 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,10 @@ TEST_F(DynamicOpenTracingDriverTest, formatErrorMessage) {
DynamicOpenTracingDriver::formatErrorMessage(error_code, "abc"));
}

// TODO (dmitri-d): memory leak is reported in this test
// Disabled due to heapcheck reporting false positives when the test is statically linked with libstdc++
// See https://github.com/envoyproxy/envoy/issues/7647 for the discussion
// TODO (dmitri-d) there currently isn't a way to resolve this: some tests will fail when libstdc++ is
// dynamically linked, this test fails when it's statically linked
TEST_F(DynamicOpenTracingDriverTest, DISABLED_InitializeDriver) {
{
std::string invalid_library = "abc123";
Expand All @@ -71,7 +74,10 @@ TEST_F(DynamicOpenTracingDriverTest, DISABLED_InitializeDriver) {
}
}

// TODO (dmitri-d): Fix "JSON supplied is not valid" error
// Disabled due to failing with "JSON supplied is not valid" error when the test is statically linked with libstdc++
// See https://github.com/envoyproxy/envoy/issues/7647 for the discussion
// TODO (dmitri-d) there currently isn't a way to resolve this: some tests will fail when libstdc++ is
// dynamically linked, this test fails when it's statically linked
TEST_F(DynamicOpenTracingDriverTest, DISABLED_FlushSpans) {
setupValidDriver();

Expand Down

0 comments on commit e6e28d9

Please sign in to comment.