Skip to content

Commit

Permalink
added an explanation why DynamicOpentracingHttpTracer has been disabl…
Browse files Browse the repository at this point in the history
…ed (maistra#4)
  • Loading branch information
Dmitri Dolguikh authored Feb 28, 2020
1 parent 7fe1986 commit 7e50506
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion test/extensions/tracers/dynamic_ot/config_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,10 @@ namespace Tracers {
namespace DynamicOt {
namespace {

// TODO (dmitri-d) fix a memory leak in the test
// Disabled due to heapcheck reporting false positives when the test is statically linked with libstdc++
// See https://github.com/envoyproxy/envoy/issues/7647 for the discussion
// TODO (dmitri-d) there currently isn't a way to resolve this: some tests will fail when libstdc++ is
// dynamically linked, this test fails when it's statically linked
TEST(DynamicOtTracerConfigTest, DISABLED_DynamicOpentracingHttpTracer) {
NiceMock<Server::MockInstance> server;
EXPECT_CALL(server.cluster_manager_, get(Eq("fake_cluster")))
Expand Down

0 comments on commit 7e50506

Please sign in to comment.