minor #408 Rebuild CI and fix CS (bocharsky-bw)

This PR was squashed before being merged into the master branch. Discussion ---------- Rebuild CI and fix CS After some changes upstream in GitHub CI config: SymfonyCasts/.github#2 Commits ------- 8da63f1 Rebuild CI and fix CS
knpuniversity · Jun 29, 2023 · 47b1c2a · 47b1c2a
2 parents 7e2d501 + 8da63f1
commit 47b1c2a
Show file tree

Hide file tree

Showing 5 changed files with 2 additions and 26 deletions.
diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
@@ -19,6 +19,8 @@ jobs:
 
     cs:
         uses: SymfonyCasts/.github/.github/workflows/php-cs-fixer.yaml@main
+        with:
+            php: '7.4'
 
     sca:
         uses: SymfonyCasts/.github/.github/workflows/phpstan.yaml@main

diff --git a/src/DependencyInjection/ProviderFactory.php b/src/DependencyInjection/ProviderFactory.php
@@ -34,8 +34,6 @@ public function __construct(UrlGeneratorInterface $generator)
      *
      * @param string $class
      * @param string $redirectUri
-     *
-     * @return mixed
      */
     public function createProvider($class, array $options, string $redirectUri = null, array $redirectParams = [], array $collaborators = [])
     {

diff --git a/src/DependencyInjection/Providers/SpotifyProviderConfigurator.php b/src/DependencyInjection/Providers/SpotifyProviderConfigurator.php
@@ -16,33 +16,21 @@
 
 class SpotifyProviderConfigurator implements ProviderConfiguratorInterface
 {
-    /**
-     * {@inheritdoc}
-     */
     public function buildConfiguration(NodeBuilder $node): void
     {
         // no custom options
     }
 
-    /**
-     * {@inheritdoc}
-     */
     public function getProviderClass(array $configuration): string
     {
         return Spotify::class;
     }
 
-    /**
-     * {@inheritdoc}
-     */
     public function getClientClass(array $config): string
     {
         return SpotifyClient::class;
     }
 
-    /**
-     * {@inheritdoc}
-     */
     public function getProviderOptions(array $configuration): array
     {
         return [
@@ -51,25 +39,16 @@ public function getProviderOptions(array $configuration): array
         ];
     }
 
-    /**
-     * {@inheritdoc}
-     */
     public function getPackagistName(): string
     {
         return 'kerox/oauth2-spotify';
     }
 
-    /**
-     * {@inheritdoc}
-     */
     public function getLibraryHomepage(): string
     {
         return 'https://github.com/ker0x/oauth2-spotify';
     }
 
-    /**
-     * {@inheritdoc}
-     */
     public function getProviderDisplayName(): string
     {
         return 'Spotify';

diff --git a/src/Security/Exception/FinishRegistrationException.php b/src/Security/Exception/FinishRegistrationException.php
@@ -10,7 +10,6 @@
 
 namespace KnpU\OAuth2ClientBundle\Security\Exception;
 
-use Exception;
 use Symfony\Component\Security\Core\Exception\AuthenticationException;
 
 /**

diff --git a/src/Security/Helper/FinishRegistrationBehavior.php b/src/Security/Helper/FinishRegistrationBehavior.php
@@ -42,8 +42,6 @@ protected function saveUserInfoToSession(Request $request, FinishRegistrationExc
     /**
      * Useful during registration to get your user information back out.
      *
-     * @return mixed
-     *
      * @throws \LogicException
      */
     public function getUserInfoFromSession(Request $request)