Cleanup and windows #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
And should (?) be redundant anyway?
weaverryan
added a commit
that referenced
this pull request
Jun 28, 2023
This PR was squashed before being merged into the main branch. Discussion ---------- Cleanup and windows Hi! 3 things: 1) Remove the different test suites from being run independently. I don't see a lot of value to this and it meant that I was accidentally running NO tests for TailwindBundle, since I didn't have the testsuites config. So I'd like to simplify. 2) Removed what I believe is an unused `phpunit` input 3) Make `runs-on` dynamic so the job could be re-used for windows. Here is a PR using this new setup: SymfonyCasts/tailwind-bundle#4 Commits ------- 41fe3e7 Cleanup and windows
weaverryan
added a commit
to SymfonyCasts/tailwind-bundle
that referenced
this pull request
Jun 28, 2023
This PR was squashed before being merged into the main branch. Discussion ---------- Adding windows to ci & fixing Windows binary bug Depends on SymfonyCasts/.github#2 * [x] Merge SymfonyCasts/.github#2 and change the CI config back to the `main` branch Fixes #2 Commits ------- 3d7aa04 Adding windows to ci & fixing Windows binary bug
|
@weaverryan cool, thanks!
I just ported those test suite calls from the repos where it was used historically... but agree, without test suites it should be more simple and robust 👍 I suppose we should rebuild every repo that uses this config to make sure they are green too? UPD: Rebuild just in case, seems everything is good :) |
This was referenced Jun 29, 2023
weaverryan
added a commit
to knpuniversity/oauth2-client-bundle
that referenced
this pull request
Jun 29, 2023
This PR was squashed before being merged into the master branch. Discussion ---------- Rebuild CI and fix CS After some changes upstream in GitHub CI config: SymfonyCasts/.github#2 Commits ------- 8da63f1 Rebuild CI and fix CS
weaverryan
added a commit
to SymfonyCasts/reset-password-bundle
that referenced
this pull request
Jun 30, 2023
This PR was squashed before being merged into the main branch. Discussion ---------- Rebuild CI and fix CS After some changes upstream in GitHub CI config: SymfonyCasts/.github#2 Commits ------- 16a7ae4 Rebuild CI and fix CS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
3 things:
Remove the different test suites from being run independently. I don't see a lot of value to this and it meant that I was accidentally running NO tests for TailwindBundle, since I didn't have the testsuites config. So I'd like to simplify.
Removed what I believe is an unused
phpunitinputMake
runs-ondynamic so the job could be re-used for windows.Here is a PR using this new setup: SymfonyCasts/tailwind-bundle#4