-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump k8s to v1.20.7 #2145
bump k8s to v1.20.7 #2145
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2145 +/- ##
==========================================
- Coverage 65.89% 65.82% -0.07%
==========================================
Files 221 221
Lines 9344 9362 +18
==========================================
+ Hits 6157 6163 +6
- Misses 2914 2923 +9
- Partials 273 276 +3
Continue to review full report at Codecov.
|
/hold I'm going to try to make a shim client that preserved pre 1.20 dynamic client behaviour |
hmm... that won't work cause they make a copy of gvrToList map |
This PR should make eventing green: knative/eventing#5477 downstream. Other changes are trivial string replacements with the exception of the client & a plugin |
/hold cancel |
/assign @n3wscott @markusthoemmes |
Doublechecked the downstream failures:
So this is LGTM! Thanks for unblocking that breaking change! |
FWIW, just looked at the client failure: |
This is accomplished by preprocessing the scheme/fixtures and declaring a custom scheme were we map our types & lists to unstructured.* types
looks like eventing adds to this scheme but we should import the correct one vs the one from the fake package
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso, markusthoemmes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The k8s lib was pinned by #569. Now pkg bumped to 1.20.7 by knative/pkg#2145 so let's drop the pin.
Fixes: #2111