Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setup proper schemes in the fake dynamic client used in unit tests #5477

Merged
merged 9 commits into from
Jun 8, 2021
Merged

setup proper schemes in the fake dynamic client used in unit tests #5477

merged 9 commits into from
Jun 8, 2021

Conversation

dprotaso
Copy link
Member

@dprotaso dprotaso commented Jun 7, 2021 •
edited
Loading

I also removed some unnecessary init functions that modified the k8s global scheme.Scheme

This should help when bumping K8s libs to 1.20

@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 7, 2021
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 7, 2021
@dprotaso
Copy link
Member Author

dprotaso commented Jun 7, 2021

Going to verify this
/hold

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 7, 2021
@dprotaso dprotaso changed the title dynamic client should have registered types in it's schema fake dynamic client should have registered types in it's schema Jun 7, 2021
@knative-prow-robot knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 7, 2021
@codecov
Copy link

codecov bot commented Jun 8, 2021 •
edited
Loading

Codecov Report

Merging #5477 (a018ef9) into main (ab3978c) will decrease coverage by 0.06%.
The diff coverage is n/a.

❗ Current head a018ef9 differs from pull request most recent head 775321f. Consider uploading reports for the commit 775321f to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5477      +/-   ##
==========================================
- Coverage   82.78%   82.71%   -0.07%     
==========================================
  Files         197      197              
  Lines        6093     6098       +5     
==========================================
  Hits         5044     5044              
- Misses        724      729       +5     
  Partials      325      325
Impacted Files Coverage Δ
pkg/channel/fanout/fanout_message_handler.go 88.05% <0.00%> (-3.42%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db83525...775321f. Read the comment docs.

@dprotaso
Copy link
Member Author

dprotaso commented Jun 8, 2021

/retest

@dprotaso dprotaso changed the title fake dynamic client should have registered types in it's schema setup proper schemes in the fake dynamic client used in unit tests Jun 8, 2021
@dprotaso
Copy link
Member Author

dprotaso commented Jun 8, 2021 •
edited
Loading

/hold cancel

Verified run: https://github.com/knative/pkg/pull/2145/checks?check_run_id=2775070136

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 8, 2021
@dprotaso
Copy link
Member Author

dprotaso commented Jun 8, 2021

/assign @vaikas

This was referenced Jun 8, 2021
Closed
Merged
@benmoss
Copy link
Member

benmoss commented Jun 8, 2021

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 8, 2021
@knative-prow-robot knative-prow-robot merged commit 28319c3 into knative:main Jun 8, 2021
@dprotaso dprotaso deleted the pre-k8s-bump branch June 8, 2021 20:13
vaikas
vaikas reviewed Jun 9, 2021
View reviewed changes
Copy link
Contributor

@vaikas vaikas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dprotaso I know this was merged already, but just curious about that one seeming duplicate entry.

pkg/reconciler/source/duck/controller_test.go
// Re-wire some injection so that an informer has a dynamic client
// with the correct scheme
ctx, _ = fakedynamicclient.With(ctx, NewScheme())
ctx, _ = fakedynamicclient.With(ctx, NewScheme())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this there twice?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoops - that's not intended

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done: #5488

@dprotaso dprotaso mentioned this pull request Jun 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vaikas vaikas vaikas left review comments

Assignees

@benmoss benmoss

@vaikas vaikas

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dprotaso @knative-prow-robot @benmoss @vaikas