Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-0.14] Have the webhook responses return TypeMeta #1450

Closed
wants to merge 2 commits into from
Closed

[release-0.14] Have the webhook responses return TypeMeta #1450

wants to merge 2 commits into from

Conversation

dprotaso
Copy link
Member

This is required for v1 APIs and it's blocking smooth upgrades from 0.14 to 0.16

knative/eventing#3409

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 25, 2020
@knative-prow-robot knative-prow-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 25, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 25, 2020
@dprotaso
Copy link
Member Author

dprotaso commented Jun 25, 2020 •
edited
Loading

Actually - we don't really test upgrades from N-2 so I'm going to close this

Upgrade Principles - https://github.com/knative/community/blob/master/mechanics/RELEASE-VERSIONING-PRINCIPLES.md#what-happens-during-upgrades-of-knative

@dprotaso dprotaso closed this Jun 25, 2020
@dprotaso dprotaso deleted the release-0.14 branch June 25, 2020 17:27
@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-pkg-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
webhook/admission.go 89.3% 92.0% 2.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattmoor mattmoor Awaiting requested review from mattmoor

@tcnghia tcnghia Awaiting requested review from tcnghia

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dprotaso @knative-prow-robot @knative-metrics-robot @googlebot