Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return TypeMeta as part of the admission response #1444

Merged
merged 1 commit into from
Jun 24, 2020
Merged

Return TypeMeta as part of the admission response #1444

merged 1 commit into from
Jun 24, 2020

Conversation

dprotaso
Copy link
Member

Unblocks knative/serving#8461

This has similar semantics to conversion reviews.

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 24, 2020
@knative-prow-robot knative-prow-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 24, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 24, 2020
@whaught
Copy link
Contributor

whaught commented Jun 24, 2020

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 24, 2020
@dprotaso
Copy link
Member Author

/hold

just validating in that serving PR

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 24, 2020
@dprotaso
Copy link
Member Author

/hold cancel

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 24, 2020
@knative-prow-robot knative-prow-robot merged commit 5be32bb into knative:master Jun 24, 2020
@dprotaso dprotaso deleted the admission-v1 branch June 24, 2020 15:54
@dprotaso dprotaso mentioned this pull request Jun 24, 2020
Merged
@anishj0shi anishj0shi mentioned this pull request Jun 24, 2020
Merged
dprotaso added a commit to dprotaso/pkg that referenced this pull request Jun 25, 2020
@dprotaso
Return TypeMeta as part of the admission response (knative#1444)
4f26dc8
dprotaso added a commit to dprotaso/pkg that referenced this pull request Jun 25, 2020
@dprotaso
Return TypeMeta as part of the admission response (knative#1444)
7ab6800
knative-prow-robot pushed a commit that referenced this pull request Jun 25, 2020
@dprotaso
[release-0.15] Have the webhook responses return TypeMeta (#1449)
dfb81cf 
* Return TypeMeta as part of the conversion response (#1433)

This is a requirement when adopting CRD v1 APIs

* Return TypeMeta as part of the admission response (#1444)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattmoor mattmoor Awaiting requested review from mattmoor

@tcnghia tcnghia Awaiting requested review from tcnghia

@whaught whaught Awaiting requested review from whaught

Assignees

@whaught whaught

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dprotaso @knative-prow-robot @whaught @googlebot