Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracing configuration json marshal/unmarshal #1228

Merged
merged 2 commits into from
Apr 22, 2020
Merged

Tracing configuration json marshal/unmarshal #1228

merged 2 commits into from
Apr 22, 2020

Conversation

slinkydeveloper
Copy link
Contributor

Needed for passing the configuration from the adapter controller to the receive adapter knative/eventing#2978

Signed-off-by: Francesco Guardiani francescoguard@gmail.com

@slinkydeveloper
Tracing configuration json marshal/unmarshal
2345aa4 
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Apr 21, 2020
@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 21, 2020
matzew
matzew reviewed Apr 21, 2020
View reviewed changes
Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

/assign @n3wscott for final approval

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 21, 2020
@slinkydeveloper slinkydeveloper mentioned this pull request Apr 21, 2020
Merged
n3wscott
n3wscott approved these changes Apr 21, 2020
View reviewed changes
Copy link
Contributor

@n3wscott n3wscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/Approve

vagababov
vagababov reviewed Apr 21, 2020
View reviewed changes
tracing/config/tracing_test.go Outdated Show resolved Hide resolved
tracing/config/tracing.go Outdated Show resolved Hide resolved
tracing/config/tracing_test.go Outdated Show resolved Hide resolved
@slinkydeveloper
Suggestions
207cad2 
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@knative-prow-robot knative-prow-robot removed the lgtm Indicates that a PR is ready to be merged. label Apr 22, 2020
@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-pkg-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
tracing/config/tracing.go 89.2% 86.2% -3.0

@matzew
Copy link
Member

matzew commented Apr 22, 2020

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 22, 2020
@matzew
Copy link
Member

matzew commented Apr 22, 2020

/approve

@matzew
Copy link
Member

matzew commented Apr 22, 2020

@n3wscott looks like your /Approve needs to be /approve 🤣

@lionelvillard
Copy link
Member

/approve

vagababov
vagababov reviewed Apr 22, 2020
View reviewed changes
Copy link
Contributor

@vagababov vagababov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lionelvillard, matzew, n3wscott, slinkydeveloper, vagababov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 22, 2020
@knative-prow-robot knative-prow-robot merged commit edb546b into knative:master Apr 22, 2020
@slinkydeveloper slinkydeveloper deleted the tracing branch April 22, 2020 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matzew matzew matzew left review comments

@vagababov vagababov vagababov left review comments

@n3wscott n3wscott n3wscott approved these changes

@dprotaso dprotaso Awaiting requested review from dprotaso

@mattmoor mattmoor Awaiting requested review from mattmoor

Assignees

@matzew matzew

@n3wscott n3wscott

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@slinkydeveloper @knative-metrics-robot @matzew @lionelvillard @knative-prow-robot @vagababov @n3wscott @googlebot