Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hard coded istio-system usage on tracing #2978

Closed
matzew opened this issue Apr 14, 2020 · 2 comments · Fixed by #3026
Closed

Hard coded istio-system usage on tracing #2978

matzew opened this issue Apr 14, 2020 · 2 comments · Fixed by #3026
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug.
Milestone

Comments

@matzew
Copy link
Member

matzew commented Apr 14, 2020

Describe the bug

Some tracing code has hard coded istio-system dependency:

Expected behavior

I guess no hard coded usage of istio-system

Knative release version
HEAD

Additional context

Perhaps related:

@matzew matzew added the kind/bug Categorizes issue or PR as related to a bug. label Apr 14, 2020
@vaikas vaikas added this to the v0.15.0 milestone Apr 20, 2020
@slinkydeveloper
Copy link
Contributor

/assign

I can take care of this one

@slinkydeveloper
Copy link
Contributor

Looks like the adapter.Main, used by most sources, uses the hardcoded istio-system config: https://github.com/knative/eventing/blob/master/pkg/adapter/main.go#L118

While other components, like the IMC dispatcher, uses a dynamic config based on config-tracing ConfigMap: https://github.com/knative/eventing/blob/master/pkg/reconciler/inmemorychannel/dispatcher/controller.go#L59

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants