We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Describe the bug
Some tracing code has hard coded istio-system dependency:
istio-system
Expected behavior
I guess no hard coded usage of istio-system
Knative release version HEAD
Additional context
Perhaps related:
The text was updated successfully, but these errors were encountered:
/assign
I can take care of this one
Sorry, something went wrong.
Looks like the adapter.Main, used by most sources, uses the hardcoded istio-system config: https://github.com/knative/eventing/blob/master/pkg/adapter/main.go#L118
adapter.Main
While other components, like the IMC dispatcher, uses a dynamic config based on config-tracing ConfigMap: https://github.com/knative/eventing/blob/master/pkg/reconciler/inmemorychannel/dispatcher/controller.go#L59
config-tracing
slinkydeveloper
Successfully merging a pull request may close this issue.
Describe the bug
Some tracing code has hard coded
istio-system
dependency:Expected behavior
I guess no hard coded usage of
istio-system
Knative release version
HEAD
Additional context
Perhaps related:
The text was updated successfully, but these errors were encountered: